webrtc/base/profiler_unittest.cc - Issue 2021743003: Disabled ProfilerTest.TestFunction due to flakiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/profiler_unittest.cc

Issue 2021743003: Disabled ProfilerTest.TestFunction due to flakiness. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/profiler_unittest.cc

diff --git a/webrtc/base/profiler_unittest.cc b/webrtc/base/profiler_unittest.cc

index 8f4421e9e91849d40ec3ca82da3a5c6b760665a5..2448fce2de62e52f3ce569d96eae5ea5aed9ada9 100644

--- a/webrtc/base/profiler_unittest.cc

+++ b/webrtc/base/profiler_unittest.cc

@@ -28,7 +28,13 @@ const char* TestFunc() {

namespace rtc {

-TEST(ProfilerTest, TestFunction) {

+// Disable this test due to flakiness; see bug 5947.

+#if defined(WEBRTC_LINUX)

+#define MAYBE_TestFunction DISABLED_TestFunction

+#else

+#define MAYBE_TestFunction TestFunction

+#endif

+TEST(ProfilerTest, MAYBE_TestFunction) {

ASSERT_TRUE(Profiler::Instance()->Clear());

// Profile a long-running function.

« no previous file with comments | « no previous file | no next file » | no next file with comments »