Remove PeerConnectionFactory's certificate generator and ref counted wrapper.

Remove PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator was that it would
reuse it with any peer connection it creates unless otherwise specified. This
generator was originally a DtlsIdentityStoreImpl store which preemptively
generated RSA-1024 in the background, giving any peer connection using RSA-1024
a head-start (generate before requesting). But now that 1) the store has been
replaced by a generator that does not do preemptive generation and 2) the
default is ECDSA, not RSA-1024, it is unnecessary for the factory to have this
code.

BUG=webrtc:5707, webrtc:5708
R=tommi@webrtc.org

Committed: https://crrev.com/cebf0a2728b3a5647258604d9f967ed62315df89
Cr-Commit-Position: refs/heads/master@{#12993}

[hbos, 2016-05-28 10:58:45]

Description was changed from

==========
Removed PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator that it would reuse
with any peer connection it creates was because the DtlsIdentityStoreImpl
previously used for this generated RSA-1024 in the background, giving any peer
connection using RSA-1024 a head-start (generate before requesting). Now that
1) the store has been replaced by a generator that does not do preemptive
generation and 2) the default is ECDSA, not RSA-1024, it is unnecessary for the
factory to have this code.

Follow-up to https://codereview.webrtc.org/2017943002/

BUG=webrtc:5707, webrtc:5708
==========

to

==========
Remove PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator that it would reuse
with any peer connection it creates was because the DtlsIdentityStoreImpl
previously used for this generated RSA-1024 in the background, giving any peer
connection using RSA-1024 a head-start (generate before requesting). Now that
1) the store has been replaced by a generator that does not do preemptive
generation and 2) the default is ECDSA, not RSA-1024, it is unnecessary for the
factory to have this code.

Follow-up to https://codereview.webrtc.org/2017943002/

BUG=webrtc:5707, webrtc:5708
==========

[hbos, 2016-05-28 10:59:04]

Description was changed from

==========
Remove PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator that it would reuse
with any peer connection it creates was because the DtlsIdentityStoreImpl
previously used for this generated RSA-1024 in the background, giving any peer
connection using RSA-1024 a head-start (generate before requesting). Now that
1) the store has been replaced by a generator that does not do preemptive
generation and 2) the default is ECDSA, not RSA-1024, it is unnecessary for the
factory to have this code.

Follow-up to https://codereview.webrtc.org/2017943002/

BUG=webrtc:5707, webrtc:5708
==========

to

==========
Remove PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator that it would reuse
with any peer connection it creates was because the DtlsIdentityStoreImpl
previously used for this generated RSA-1024 in the background, giving any peer
connection using RSA-1024 a head-start (generate before requesting). Now that
1) the store has been replaced by a generator that does not do preemptive
generation and 2) the default is ECDSA, not RSA-1024, it is unnecessary for the
factory to have this code.

Follow-up to https://codereview.webrtc.org/2017943002/

BUG=webrtc:5707, webrtc:5708
==========

[hbos, 2016-06-01 09:53:02]

Patchset #1 (id:1) has been deleted

[hbos, 2016-06-01 09:56:00]

Description was changed from

==========
Remove PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator that it would reuse
with any peer connection it creates was because the DtlsIdentityStoreImpl
previously used for this generated RSA-1024 in the background, giving any peer
connection using RSA-1024 a head-start (generate before requesting). Now that
1) the store has been replaced by a generator that does not do preemptive
generation and 2) the default is ECDSA, not RSA-1024, it is unnecessary for the
factory to have this code.

Follow-up to https://codereview.webrtc.org/2017943002/

BUG=webrtc:5707, webrtc:5708
==========

to

==========
Remove PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator was that it would
reuse it with any peer connection it creates unless otherwise specified. This
generator was originally a DtlsIdentityStoreImpl store which preemptively
generated RSA-1024 in the background, giving any peer connection using RSA-1024
a head-start (generate before requesting). But now that 1) the store has been
replaced by a generator that does not do preemptive generation and 2) the
default is ECDSA, not RSA-1024, it is unnecessary for the factory to have this
code.

BUG=webrtc:5707, webrtc:5708
==========

[hbos, 2016-06-01 10:08:55]

hbos@webrtc.org changed reviewers:
+ tommi@webrtc.org

[hbos, 2016-06-01 10:08:56]

Please take a look tommi.

https://codereview.webrtc.org/2021663002/diff/20001/webrtc/api/peerconnection...
File webrtc/api/peerconnectionfactory.cc (right):

https://codereview.webrtc.org/2021663002/diff/20001/webrtc/api/peerconnection...
webrtc/api/peerconnectionfactory.cc:251: new
rtc::RTCCertificateGenerator(signaling_thread_, network_thread_));
Using network_thread_ instead of worker_thread_ here because that was what
cert_generator_ (line 190) previously used - to my surprise - even though old
code (store) and new code (generator) calls the thread it does certificate
generation on the worker_thread_. (Which I thought meant it was THE webrtc
worker thread!)

I would happily change it to use worker_thread_ however. If it matters much.
Thoughts?

[tommi, 2016-06-01 12:44:59]

lgtm

https://codereview.webrtc.org/2021663002/diff/20001/webrtc/api/peerconnection...
File webrtc/api/peerconnectionfactory.cc (right):

https://codereview.webrtc.org/2021663002/diff/20001/webrtc/api/peerconnection...
webrtc/api/peerconnectionfactory.cc:251: new
rtc::RTCCertificateGenerator(signaling_thread_, network_thread_));
On 2016/06/01 10:08:56, hbos wrote:
> Using network_thread_ instead of worker_thread_ here because that was what
> cert_generator_ (line 190) previously used - to my surprise - even though old
> code (store) and new code (generator) calls the thread it does certificate
> generation on the worker_thread_. (Which I thought meant it was THE webrtc
> worker thread!)
> 
> I would happily change it to use worker_thread_ however. If it matters much.
> Thoughts?

Keeping the existing behaviour makes sense.  You could check with holmer@ though
and see what he thinks.

[hbos, 2016-06-01 13:45:45]

Description was changed from

==========
Remove PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator was that it would
reuse it with any peer connection it creates unless otherwise specified. This
generator was originally a DtlsIdentityStoreImpl store which preemptively
generated RSA-1024 in the background, giving any peer connection using RSA-1024
a head-start (generate before requesting). But now that 1) the store has been
replaced by a generator that does not do preemptive generation and 2) the
default is ECDSA, not RSA-1024, it is unnecessary for the factory to have this
code.

BUG=webrtc:5707, webrtc:5708
==========

to

==========
Remove PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator was that it would
reuse it with any peer connection it creates unless otherwise specified. This
generator was originally a DtlsIdentityStoreImpl store which preemptively
generated RSA-1024 in the background, giving any peer connection using RSA-1024
a head-start (generate before requesting). But now that 1) the store has been
replaced by a generator that does not do preemptive generation and 2) the
default is ECDSA, not RSA-1024, it is unnecessary for the factory to have this
code.

BUG=webrtc:5707, webrtc:5708
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/cebf0a2728b3a5647258604d9...
==========

[commit-bot: I haz the power, 2016-06-01 13:45:46]

Description was changed from

==========
Remove PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator was that it would
reuse it with any peer connection it creates unless otherwise specified. This
generator was originally a DtlsIdentityStoreImpl store which preemptively
generated RSA-1024 in the background, giving any peer connection using RSA-1024
a head-start (generate before requesting). But now that 1) the store has been
replaced by a generator that does not do preemptive generation and 2) the
default is ECDSA, not RSA-1024, it is unnecessary for the factory to have this
code.

BUG=webrtc:5707, webrtc:5708
==========

to

==========
Remove PeerConnectionFactory's certificate generator and ref counted wrapper.
Clean-up.

The idea behind the factory having a certificate generator was that it would
reuse it with any peer connection it creates unless otherwise specified. This
generator was originally a DtlsIdentityStoreImpl store which preemptively
generated RSA-1024 in the background, giving any peer connection using RSA-1024
a head-start (generate before requesting). But now that 1) the store has been
replaced by a generator that does not do preemptive generation and 2) the
default is ECDSA, not RSA-1024, it is unnecessary for the factory to have this
code.

BUG=webrtc:5707, webrtc:5708
R=tommi@webrtc.org

Committed: https://crrev.com/cebf0a2728b3a5647258604d9f967ed62315df89
Cr-Commit-Position: refs/heads/master@{#12993}
==========

[commit-bot: I haz the power, 2016-06-01 13:45:46]

Patchset 1 (id:??) landed as
https://crrev.com/cebf0a2728b3a5647258604d9f967ed62315df89
Cr-Commit-Position: refs/heads/master@{#12993}

[hbos, 2016-06-01 13:45:47]

Committed patchset #1 (id:20001) manually as
cebf0a2728b3a5647258604d9f967ed62315df89 (presubmit successful).