Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2021243002:
GN: Add test_support_unittests target (Closed)
|
Created:
4 years, 6 months ago by kjellander_webrtc Modified:
4 years, 6 months ago Reviewers:
phoglund CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionGN: Add test_support_unittests target
BUG=webrtc:5949
TESTED=Passing run on Linux, Windows and Mac:
gn gen out/Default
ninja -C out/Default
out/Default/test_support_unittests
And for Android:
gn gen out/Default --args='target_os="android" target_cpu="arm"'
ninja -C out/Default
out/Default/bin/run_test_support_unittests
NOTRY=True
Committed: https://crrev.com/0f380d8ffafe0397c70e54a2fa3fd1571ae9d636
Cr-Commit-Position: refs/heads/master@{#12989}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Removing test_support_main_threaded_mac from all target and fix Win warning #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== GN: Add test_support_unittests target BUG=webrtc:5949 ========== to ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux: gn gen out/Default ninja -C out/Default out/test_support_unittests And on Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests ==========
kjellander@webrtc.org changed reviewers: + phoglund@webrtc.org
Description was changed from ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux: gn gen out/Default ninja -C out/Default out/test_support_unittests And on Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests ========== to ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux: gn gen out/Default ninja -C out/Default out/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests ==========
https://codereview.webrtc.org/2021243002/diff/1/webrtc/test/test.gyp File webrtc/test/test.gyp (right): https://codereview.webrtc.org/2021243002/diff/1/webrtc/test/test.gyp#newcode280 webrtc/test/test.gyp:280: ['OS!="win"', { The changes in this file are just to eliminate sources! exclusions, since they make it harder to read GYP and also harder to compare with the GN file (which disallows removing sources from existing sets)
Patchset #2 (id:20001) has been deleted
Not sure if I'm a good reviewer for this, but I didn't find any obvious problems. https://codereview.webrtc.org/2021243002/diff/40001/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (right): https://codereview.webrtc.org/2021243002/diff/40001/webrtc/test/BUILD.gn#newc... webrtc/test/BUILD.gn:36: # GN orders flags on a target before flags from configs. The default config Nit: 80 chars https://codereview.webrtc.org/2021243002/diff/40001/webrtc/test/BUILD.gn#newc... webrtc/test/BUILD.gn:307: # This needs to be kept in sync with the test_support_unittests.isolate file. Nit: 80 chars
lgtm
Description was changed from ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux: gn gen out/Default ninja -C out/Default out/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests ========== to ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux: gn gen out/Default ninja -C out/Default out/Default/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests ==========
Description was changed from ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux: gn gen out/Default ninja -C out/Default out/Default/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests ========== to ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux, Windows and Mac: gn gen out/Default ninja -C out/Default out/Default/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests ==========
Patchset #2 (id:40001) has been deleted
Description was changed from ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux, Windows and Mac: gn gen out/Default ninja -C out/Default out/Default/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests ========== to ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux, Windows and Mac: gn gen out/Default ninja -C out/Default out/Default/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests NOTRY=True ==========
The CQ bit was checked by kjellander@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from phoglund@webrtc.org Link to the patchset: https://codereview.webrtc.org/2021243002/#ps60001 (title: "Removing test_support_main_threaded_mac from all target and fix Win warning")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021243002/60001
Message was sent while issue was closed.
Description was changed from ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux, Windows and Mac: gn gen out/Default ninja -C out/Default out/Default/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests NOTRY=True ========== to ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux, Windows and Mac: gn gen out/Default ninja -C out/Default out/Default/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux, Windows and Mac: gn gen out/Default ninja -C out/Default out/Default/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests NOTRY=True ========== to ========== GN: Add test_support_unittests target BUG=webrtc:5949 TESTED=Passing run on Linux, Windows and Mac: gn gen out/Default ninja -C out/Default out/Default/test_support_unittests And for Android: gn gen out/Default --args='target_os="android" target_cpu="arm"' ninja -C out/Default out/Default/bin/run_test_support_unittests NOTRY=True Committed: https://crrev.com/0f380d8ffafe0397c70e54a2fa3fd1571ae9d636 Cr-Commit-Position: refs/heads/master@{#12989} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0f380d8ffafe0397c70e54a2fa3fd1571ae9d636 Cr-Commit-Position: refs/heads/master@{#12989} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
