Revert of Android: Change camera fps range selection

Revert of Android: Change camera fps range selection (patchset #4 id:100001 of https://codereview.webrtc.org/2013413002/ )

Reason for revert:
Breaks chromium fyi:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/13565
on step 'generate_build_files':
gyp: /b/build/slave/Mac_Builder/build/src/third_party/build/android/test_runner.gypi not found

Original issue's description:
> Android: Change camera fps range selection
>
> This CL changes the logic in
> CameraEnumerationAndroid.getClosestSupportedFramerateRange() to prefer
> fps ranges with a low lower bound so the camera can adjust for
> brightness conditions.
>
> To test the functionality of the fps range selection, JUnit tests are
> added. This required a new target in api_tests.gyp. JUnit tests are
> preferable over instrumentation tests
> (libjingle_peerconnection_android_unittest) because they are faster and
> simpler.
>
> R=kjellander@webrtc.org, sakal@webrtc.org
>
> Committed: https://crrev.com/b4ddb5c3d3706b1c02437f6a538576f3552ab908
> Cr-Commit-Position: refs/heads/master@{#12964}

TBR=sakal@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/b3f208d0ba45f140272e3e705b5cdadc3c76514b
Cr-Commit-Position: refs/heads/master@{#12966}

[magjed_webrtc, 2016-05-31 08:44:17]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-05-31 08:44:17]

Created Revert of Android: Change camera fps range selection

[commit-bot: I haz the power, 2016-05-31 08:44:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2021233002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2021233002/1

[commit-bot: I haz the power, 2016-05-31 08:44:31]

Description was changed from

==========
Revert of Android: Change camera fps range selection (patchset #4 id:100001 of
https://codereview.webrtc.org/2013413002/ )

Reason for revert:
Breaks chromium fyi:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
on step 'generate_build_files':
gyp:
/b/build/slave/Mac_Builder/build/src/third_party/build/android/test_runner.gypi
not found

Original issue's description:
> Android: Change camera fps range selection
> 
> This CL changes the logic in
> CameraEnumerationAndroid.getClosestSupportedFramerateRange() to prefer
> fps ranges with a low lower bound so the camera can adjust for
> brightness conditions.
> 
> To test the functionality of the fps range selection, JUnit tests are
> added. This required a new target in api_tests.gyp. JUnit tests are
> preferable over instrumentation tests
> (libjingle_peerconnection_android_unittest) because they are faster and
> simpler.
> 
> R=kjellander@webrtc.org, sakal@webrtc.org
> 
> Committed: https://crrev.com/b4ddb5c3d3706b1c02437f6a538576f3552ab908
> Cr-Commit-Position: refs/heads/master@{#12964}

TBR=sakal@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Android: Change camera fps range selection (patchset #4 id:100001 of
https://codereview.webrtc.org/2013413002/ )

Reason for revert:
Breaks chromium fyi:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
on step 'generate_build_files':
gyp:
/b/build/slave/Mac_Builder/build/src/third_party/build/android/test_runner.gypi
not found

Original issue's description:
> Android: Change camera fps range selection
> 
> This CL changes the logic in
> CameraEnumerationAndroid.getClosestSupportedFramerateRange() to prefer
> fps ranges with a low lower bound so the camera can adjust for
> brightness conditions.
> 
> To test the functionality of the fps range selection, JUnit tests are
> added. This required a new target in api_tests.gyp. JUnit tests are
> preferable over instrumentation tests
> (libjingle_peerconnection_android_unittest) because they are faster and
> simpler.
> 
> R=kjellander@webrtc.org, sakal@webrtc.org
> 
> Committed: https://crrev.com/b4ddb5c3d3706b1c02437f6a538576f3552ab908
> Cr-Commit-Position: refs/heads/master@{#12964}

TBR=sakal@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[commit-bot: I haz the power, 2016-05-31 08:44:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-31 08:44:42]

Description was changed from

==========
Revert of Android: Change camera fps range selection (patchset #4 id:100001 of
https://codereview.webrtc.org/2013413002/ )

Reason for revert:
Breaks chromium fyi:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
on step 'generate_build_files':
gyp:
/b/build/slave/Mac_Builder/build/src/third_party/build/android/test_runner.gypi
not found

Original issue's description:
> Android: Change camera fps range selection
> 
> This CL changes the logic in
> CameraEnumerationAndroid.getClosestSupportedFramerateRange() to prefer
> fps ranges with a low lower bound so the camera can adjust for
> brightness conditions.
> 
> To test the functionality of the fps range selection, JUnit tests are
> added. This required a new target in api_tests.gyp. JUnit tests are
> preferable over instrumentation tests
> (libjingle_peerconnection_android_unittest) because they are faster and
> simpler.
> 
> R=kjellander@webrtc.org, sakal@webrtc.org
> 
> Committed: https://crrev.com/b4ddb5c3d3706b1c02437f6a538576f3552ab908
> Cr-Commit-Position: refs/heads/master@{#12964}

TBR=sakal@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Android: Change camera fps range selection (patchset #4 id:100001 of
https://codereview.webrtc.org/2013413002/ )

Reason for revert:
Breaks chromium fyi:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
on step 'generate_build_files':
gyp:
/b/build/slave/Mac_Builder/build/src/third_party/build/android/test_runner.gypi
not found

Original issue's description:
> Android: Change camera fps range selection
>
> This CL changes the logic in
> CameraEnumerationAndroid.getClosestSupportedFramerateRange() to prefer
> fps ranges with a low lower bound so the camera can adjust for
> brightness conditions.
>
> To test the functionality of the fps range selection, JUnit tests are
> added. This required a new target in api_tests.gyp. JUnit tests are
> preferable over instrumentation tests
> (libjingle_peerconnection_android_unittest) because they are faster and
> simpler.
>
> R=kjellander@webrtc.org, sakal@webrtc.org
>
> Committed: https://crrev.com/b4ddb5c3d3706b1c02437f6a538576f3552ab908
> Cr-Commit-Position: refs/heads/master@{#12964}

TBR=sakal@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/b3f208d0ba45f140272e3e705b5cdadc3c76514b
Cr-Commit-Position: refs/heads/master@{#12966}
==========

[commit-bot: I haz the power, 2016-05-31 08:44:43]

Patchset 1 (id:??) landed as
https://crrev.com/b3f208d0ba45f140272e3e705b5cdadc3c76514b
Cr-Commit-Position: refs/heads/master@{#12966}

[kjellander_webrtc, 2016-05-31 09:04:06]

lgtm, I'll help you untangle the GYP magic here. I should have thought about
something like this could happen for this considering the hacks we had to
implement for the APK tests.

Luckily this goes away when we migrate to GN, which is my highest priority right
now.

[magjed_webrtc, 2016-05-31 11:26:58]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2028583002/ by magjed@webrtc.org.

The reason for reverting is: Fixed gyp bug..