Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2020783003: Revert of Change ProcessThread's task type to be the one from TaskQueue. (Closed)

Created:
4 years, 6 months ago by tommi
Modified:
4 years, 6 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Change ProcessThread's task type to be the one from TaskQueue. (patchset #3 id:80001 of https://codereview.webrtc.org/2016043003/ ) Reason for revert: Downstream issues Original issue's description: > Change ProcessThread's task type to be the one from TaskQueue. > ProcessThread will eventually be replaced by TaskQueue, so this is the first little step. > > BUG= > R=magjed@webrtc.org > > Committed: https://crrev.com/400a276c8a0b299190ff17a81edd8780a26d63d3 > Cr-Commit-Position: refs/heads/master@{#12952} TBR=magjed@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/641455176a1241dea6dda7071ba4162f41a0b5fc Cr-Commit-Position: refs/heads/master@{#12953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -31 lines) Patch
M webrtc/modules/utility/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/utility/include/mock/mock_process_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/include/process_thread.h View 2 chunks +9 lines, -15 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M webrtc/modules/utility/utility.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/jitter_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tommi
Created Revert of Change ProcessThread's task type to be the one from TaskQueue.
4 years, 6 months ago (2016-05-28 17:02:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020783003/1
4 years, 6 months ago (2016-05-28 17:02:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-28 18:00:34 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/641455176a1241dea6dda7071ba4162f41a0b5fc Cr-Commit-Position: refs/heads/master@{#12953}
4 years, 6 months ago (2016-05-28 18:00:47 UTC) #6
tommi
4 years, 6 months ago (2016-05-28 21:57:03 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2017333002/ by tommi@webrtc.org.

The reason for reverting is: Reland. It was a false alarm..

Powered by Google App Engine
This is Rietveld 408576698