webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h - Issue 2020593002: Refactor scaling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

Issue 2020593002: Refactor scaling. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Address Per's comments. Add I420Buffer::Scale helper method. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/common_video/include/video_frame_buffer.h ('K') | « webrtc/media/engine/webrtcvideoframe_unittest.cc ('k') | webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc » ('j') | webrtc/modules/video_coding/codecs/test/videoprocessor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

index 5dfcf9f60a032e6ffec98b5644b9813003e2a677..c8ae495eb32f9f37cf7f286b364eaa9160c959b3 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

+++ b/webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h

@@ -70,7 +70,8 @@ class H264VideoToolboxEncoder : public H264Encoder {

int ResetCompressionSession();

void ConfigureCompressionSession();

void DestroyCompressionSession();

- const VideoFrame& GetScaledFrameOnEncode(const VideoFrame& frame);

+ rtc::scoped_refptr<VideoFrameBuffer> GetScaledBufferOnEncode(

+ const rtc::scoped_refptr<VideoFrameBuffer>& frame);

void SetBitrateBps(uint32_t bitrate_bps);

void SetEncoderBitrateBps(uint32_t bitrate_bps);