Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: webrtc/api/java/jni/androidvideocapturer_jni.cc

Issue 2020593002: Refactor scaling. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Clarify some comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/java/jni/androidvideocapturer_jni.cc
diff --git a/webrtc/api/java/jni/androidvideocapturer_jni.cc b/webrtc/api/java/jni/androidvideocapturer_jni.cc
index 0abc9c0d51b9c987df660924b8b9a2a6f1006288..cd0a81fc6c02c997e1e8f77114184e5a6f636d47 100644
--- a/webrtc/api/java/jni/androidvideocapturer_jni.cc
+++ b/webrtc/api/java/jni/androidvideocapturer_jni.cc
@@ -13,7 +13,6 @@
#include "webrtc/api/java/jni/native_handle_impl.h"
#include "webrtc/api/java/jni/surfacetexturehelper_jni.h"
#include "third_party/libyuv/include/libyuv/convert.h"
-#include "third_party/libyuv/include/libyuv/scale.h"
#include "webrtc/base/bind.h"
namespace webrtc_jni {
@@ -216,23 +215,9 @@ void AndroidVideoCapturerJni::OnMemoryBufferFrame(void* video_frame,
capturer_->apply_rotation() ? rotation : 0));
if (adapted_width != rotated_width || adapted_height != rotated_height) {
- rtc::scoped_refptr<webrtc::VideoFrameBuffer> scaled =
- post_scale_pool_.CreateBuffer(adapted_width, adapted_height);
- // TODO(nisse): This should be done by some Scale method in
- // I420Buffer, but we can't do that right now, since
- // I420BufferPool uses a wrapper object.
- if (libyuv::I420Scale(buffer->DataY(), buffer->StrideY(),
- buffer->DataU(), buffer->StrideU(),
- buffer->DataV(), buffer->StrideV(),
- rotated_width, rotated_height,
- scaled->MutableDataY(), scaled->StrideY(),
- scaled->MutableDataU(), scaled->StrideU(),
- scaled->MutableDataV(), scaled->StrideV(),
- adapted_width, adapted_height,
- libyuv::kFilterBox) < 0) {
- LOG(LS_WARNING) << "I420Scale failed";
- return;
- }
+ rtc::scoped_refptr<webrtc::I420Buffer> scaled =
+ post_scale_pool_.CreateBuffer(adapted_width, adapted_height);
+ scaled->CropAndScale(buffer, 0, 0, rotated_width, rotated_height);
perkj_webrtc 2016/06/02 13:43:08 please use buffer->width() and buffer->height()
nisse-webrtc 2016/06/03 13:55:01 Done.
buffer = scaled;
}
// TODO(nisse): Use microsecond time instead.

Powered by Google App Engine
This is Rietveld 408576698