webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc - Issue 2020593002: Refactor scaling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc

Issue 2020593002: Refactor scaling. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Delete ShallowCenterCrop. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/codecs/test/videoprocessor.cc ('K') | « webrtc/modules/video_coding/codecs/test/videoprocessor.cc ('k') | webrtc/modules/video_coding/codecs/vp8/vp8_impl.h » ('j') | webrtc/modules/video_coding/utility/quality_scaler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc

diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc

index 9f361dc62614dea9f0e6b6f7aaa41f4d344b14d5..706e57a0e5de450e09e12d5fb193c758f026483c 100644

--- a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc

+++ b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc

@@ -525,8 +525,8 @@ class VideoProcessorIntegrationTest : public testing::Test {

EXPECT_GT(psnr_result.min, quality_metrics.minimum_min_psnr);

EXPECT_GT(ssim_result.average, quality_metrics.minimum_avg_ssim);

EXPECT_GT(ssim_result.min, quality_metrics.minimum_min_ssim);

- if (!remove(config_.output_filename.c_str())) {

- fprintf(stderr, "Failed to remove temporary file!");

+ if (remove(config_.output_filename.c_str()) < 0) {

nisse-webrtc 2016/06/01 09:15:18 This is a very unrelated bugfix, I was annoyed by

+ fprintf(stderr, "Failed to remove temporary file!\n");

}

};