AudioDecoderIsacT: Require caller to always specify sample rate

webrtc/modules/utility/source/coder.cc

Index: webrtc/modules/utility/source/coder.cc
diff --git a/webrtc/modules/utility/source/coder.cc b/webrtc/modules/utility/source/coder.cc
index 248cd488b6dea7e16552fcbd42da74adaac94250..f2ae43eb108a939f261ae17646a05c26fd307643 100644
--- a/webrtc/modules/utility/source/coder.cc
+++ b/webrtc/modules/utility/source/coder.cc
@@ -45,8 +45,9 @@ int32_t AudioCoder::SetEncodeCodec(const CodecInst& codec_inst) {
 }
 
 int32_t AudioCoder::SetDecodeCodec(const CodecInst& codec_inst) {
-  if (acm_->RegisterReceiveCodec(
-          codec_inst, [&] { return rent_a_codec_.RentIsacDecoder(); }) == -1) {
+  if (acm_->RegisterReceiveCodec(codec_inst, [&] {

[perkj_webrtc, 2016/06/01 20:04:40]

FYI capture all lambdas are not allowed according to google style guide. One
reason being that its too easy to make lifetime mistakes. 
 

[kwiberg-webrtc, 2016/06/02 08:23:16]

They relaxed the rules slightly (some months ago IIRC). The relevant part now
reads, "Use default captures judiciously, when it aids readability. In
particular, prefer to write lambda captures explicitly when capturing this or if
the lambda will escape the current scope."

In this case, the lambda will not escape the current scope (because
RegisterReceiveCodec will just invoke it, not save it), so a default capture is
fine.

+        return rent_a_codec_.RentIsacDecoder(codec_inst.plfreq);
+      }) == -1) {
     return -1;
   }
   memcpy(&receive_codec_, &codec_inst, sizeof(CodecInst));