Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: webrtc/test/BUILD.gn

Issue 2020343003: GN: Replace Windows suppressions of warning 4267 with config. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/system_wrappers/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/BUILD.gn
diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn
index 631645e99a23643832e49e223dce469b809bf13a..451514089aa6647e9c4b49cfcc19ad13c0d93c7f 100644
--- a/webrtc/test/BUILD.gn
+++ b/webrtc/test/BUILD.gn
@@ -288,12 +288,11 @@ test("test_support_unittests") {
configs += [ "..:common_config" ]
public_configs = [ "..:common_inherited_config" ]
+ # TODO(jschuh): Bug 1348: fix this warning.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
if (is_win) {
- cflags = [
- # TODO(jschuh): Bug 1348: fix this warning.
- "/wd4267", # size_t to int truncations
- "/wd4373", # virtual override w/different const/volatile signature.
- ]
+ cflags = [ "/wd4373" ] # virtual override w/different const/volatile signature.
}
if (is_clang) {
« no previous file with comments | « webrtc/system_wrappers/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698