Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2020213002: Rename APK tests workaround to make it more generic. (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), the sun, Andrew MacDonald, zhengzhonghou_agora.io, fengyue_agora.io, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, mflodman, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename APK tests workaround to make it more generic. We plan to add junit tests running with Robolectric so naming these files "apk" is slightly confusing. NOTRY=True Committed: https://crrev.com/208d19845df447fdf8f85cab8fa5d0608253247e Cr-Commit-Position: refs/heads/master@{#12971}

Patch Set 1 #

Patch Set 2 : Add owners wildcard for GYP in webrtc/api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -377 lines) Patch
M webrtc/api/OWNERS View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/api/api_tests.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
A + webrtc/build/android_tests.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/build/android_tests_noop.gyp View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/build/apk_tests.gyp View 1 chunk +0 lines, -267 lines 0 comments Download
D webrtc/build/apk_tests_noop.gyp View 1 chunk +0 lines, -73 lines 0 comments Download
M webrtc/build/common.gypi View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/common_audio/common_audio.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_video/common_video_unittests.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/modules.gyp View 5 chunks +8 lines, -8 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers_tests.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/test/test.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/tools/tools.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kjellander_webrtc
4 years, 6 months ago (2016-05-31 09:28:39 UTC) #2
magjed_webrtc
lgtm
4 years, 6 months ago (2016-05-31 09:30:12 UTC) #3
kjellander_webrtc
+henrika for webrtc/api/OWNERS approval
4 years, 6 months ago (2016-05-31 09:34:18 UTC) #6
henrika_webrtc
LGTM
4 years, 6 months ago (2016-05-31 09:54:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020213002/20001
4 years, 6 months ago (2016-05-31 10:59:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 11:01:43 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 11:01:53 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/208d19845df447fdf8f85cab8fa5d0608253247e
Cr-Commit-Position: refs/heads/master@{#12971}

Powered by Google App Engine
This is Rietveld 408576698