Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2020203002: [rtcp] RapidResyncRequest::Parse updated not to use RTCPUtility (Closed)

Created:
4 years, 6 months ago by danilchap
Modified:
4 years, 6 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] RapidResyncRequest::Parse updated not to use RTCPUtility BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/938c5ddf0b6b4877a78f90e4162bf11686dbc251 Cr-Commit-Position: refs/heads/master@{#12972}

Patch Set 1 #

Patch Set 2 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -30 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rapid_resync_request.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rapid_resync_request.cc View 1 2 chunks +8 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rapid_resync_request_unittest.cc View 3 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
åsapersson
lgtm
4 years, 6 months ago (2016-05-31 09:49:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020203002/1
4 years, 6 months ago (2016-05-31 09:49:57 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios64_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_dbg/builds/148) mac_baremetal on tryserver.webrtc (JOB_FAILED, ...
4 years, 6 months ago (2016-05-31 09:51:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020203002/20001
4 years, 6 months ago (2016-05-31 11:28:23 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 11:30:59 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 11:31:07 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/938c5ddf0b6b4877a78f90e4162bf11686dbc251
Cr-Commit-Position: refs/heads/master@{#12972}

Powered by Google App Engine
This is Rietveld 408576698