Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2018703002: Increasing "converge" time for remote candidate pair selection in test. (Closed)

Created:
4 years, 6 months ago by Taylor Brandstetter
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increasing "converge" time for remote candidate pair selection in test. The local endpoint was given 4 seconds to converge but the remote endpoint was only given 1 second. Now they both collectively have 4 seconds. Also fixed the ExpectCandidate2 method (used for verbose failure logging) and removed a bunch of dead code. TBR=pthatcher@webrtc.org Committed: https://crrev.com/7e1b8fbb453526525f4c02d9915f2ae3db23f3fa Cr-Commit-Position: refs/heads/master@{#12934}

Patch Set 1 #

Patch Set 2 : Removing unrelated files from CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -120 lines) Patch
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 5 chunks +27 lines, -120 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
Taylor Brandstetter
4 years, 6 months ago (2016-05-26 21:34:58 UTC) #3
Taylor Brandstetter
4 years, 6 months ago (2016-05-26 22:14:29 UTC) #7
Taylor Brandstetter
4 years, 6 months ago (2016-05-26 22:22:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7e1b8fbb453526525f4c02d9915f2ae3db23f3fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698