webrtc/p2p/base/p2ptransportchannel.h - Issue 2018693002: Create a new connection if a candidate reuses an address

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/p2ptransportchannel.h

Issue 2018693002: Create a new connection if a candidate reuses an address (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Sync with head Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/p2p/base/p2ptransportchannel.h

diff --git a/webrtc/p2p/base/p2ptransportchannel.h b/webrtc/p2p/base/p2ptransportchannel.h

index ada3ecfb8bb2deeb6bc5d9120eb1647d7cd1a1da..d3934fd4b7fb4f08eeb01a684d011bcbcafdbe77 100644

--- a/webrtc/p2p/base/p2ptransportchannel.h

+++ b/webrtc/p2p/base/p2ptransportchannel.h

@@ -220,6 +220,9 @@ class P2PTransportChannel : public TransportChannelImpl,

bool CreateConnection(PortInterface* port,

const Candidate& remote_candidate,

PortInterface* origin_port);

+ bool MaybeCreateConnection(PortInterface* port,

+ const Candidate& remote_candidate,

+ PortInterface* origin_port);

pthatcher1 2016/05/27 18:42:54 Can you leave a comment explaining when we create

honghaiz3 2016/05/31 18:57:31 Removed the maybe method.

bool FindConnection(cricket::Connection* connection) const;

uint32_t GetRemoteCandidateGeneration(const Candidate& candidate);

« no previous file with comments | « no previous file | webrtc/p2p/base/p2ptransportchannel.cc » ('j') | webrtc/p2p/base/p2ptransportchannel.cc » ('J')