Chromium Code Reviews

Issue 2018693002: Create a new connection if a candidate reuses an address (Closed)

Created:
4 years, 7 months ago by honghaiz3
Modified:
4 years, 6 months ago
Reviewers:
Taylor Brandstetter, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Create a new connection if a candidate reuses an address If the remote side sends a candidate with the same address and port with an existing candidate, but with a new ufrag and pwd, the local client will create a new connection from it and destroy the old connection with the same remote address. BUG=webrtc:5915 Committed: https://crrev.com/36f50e8e4e3e947ad8db1179e358b11431a8f079 Cr-Commit-Position: refs/heads/master@{#13000}

Patch Set 1 : #

Patch Set 2 : Sync with head #

Total comments: 16

Patch Set 3 : #

Total comments: 8

Patch Set 4 : #

Total comments: 2

Patch Set 5 : address comments #

Unified diffs Side-by-side diffs Stats (+140 lines, -37 lines)
M webrtc/p2p/base/p2ptransportchannel.cc View 1 chunk +26 lines, -25 lines 0 comments
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 2 chunks +58 lines, -0 lines 0 comments
M webrtc/p2p/base/port.h View 2 chunks +7 lines, -2 lines 0 comments
M webrtc/p2p/base/port.cc View 2 chunks +14 lines, -2 lines 0 comments
M webrtc/p2p/base/port_unittest.cc View 2 chunks +29 lines, -1 line 0 comments
M webrtc/p2p/base/relayport.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/p2p/base/stunport.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/p2p/base/tcpport.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/p2p/base/turnport.h View 2 chunks +1 line, -1 line 0 comments
M webrtc/p2p/base/turnport.cc View 2 chunks +2 lines, -3 lines 0 comments

Messages

Total messages: 27 (15 generated)
honghaiz3
PTAL.
4 years, 6 months ago (2016-05-27 17:23:27 UTC) #8
pthatcher1
Thanks for making a change so quickly. https://codereview.webrtc.org/2018693002/diff/80001/webrtc/p2p/base/p2ptransportchannel.cc File webrtc/p2p/base/p2ptransportchannel.cc (right): https://codereview.webrtc.org/2018693002/diff/80001/webrtc/p2p/base/p2ptransportchannel.cc#newcode885 webrtc/p2p/base/p2ptransportchannel.cc:885: PortInterface* origin_port) ...
4 years, 6 months ago (2016-05-27 18:42:54 UTC) #9
honghaiz3
PTAL. https://codereview.webrtc.org/2018693002/diff/80001/webrtc/p2p/base/p2ptransportchannel.cc File webrtc/p2p/base/p2ptransportchannel.cc (right): https://codereview.webrtc.org/2018693002/diff/80001/webrtc/p2p/base/p2ptransportchannel.cc#newcode885 webrtc/p2p/base/p2ptransportchannel.cc:885: PortInterface* origin_port) { On 2016/05/27 18:42:54, pthatcher1 wrote: ...
4 years, 6 months ago (2016-05-31 18:57:32 UTC) #11
pthatcher1
https://codereview.webrtc.org/2018693002/diff/80001/webrtc/p2p/base/port.cc File webrtc/p2p/base/port.cc (right): https://codereview.webrtc.org/2018693002/diff/80001/webrtc/p2p/base/port.cc#newcode283 webrtc/p2p/base/port.cc:283: ret.first->second = conn; On 2016/05/31 18:57:31, honghaiz3 wrote: > ...
4 years, 6 months ago (2016-05-31 20:09:30 UTC) #12
honghaiz3
PTAL. https://codereview.webrtc.org/2018693002/diff/120001/webrtc/p2p/base/p2ptransportchannel.cc File webrtc/p2p/base/p2ptransportchannel.cc (right): https://codereview.webrtc.org/2018693002/diff/120001/webrtc/p2p/base/p2ptransportchannel.cc#newcode874 webrtc/p2p/base/p2ptransportchannel.cc:874: AddConnection(connection); On 2016/05/31 20:09:29, pthatcher1 wrote: > I ...
4 years, 6 months ago (2016-05-31 23:25:23 UTC) #14
pthatcher1
lgtm https://codereview.webrtc.org/2018693002/diff/120001/webrtc/p2p/base/p2ptransportchannel.cc File webrtc/p2p/base/p2ptransportchannel.cc (right): https://codereview.webrtc.org/2018693002/diff/120001/webrtc/p2p/base/p2ptransportchannel.cc#newcode874 webrtc/p2p/base/p2ptransportchannel.cc:874: AddConnection(connection); On 2016/05/31 23:25:23, honghaiz3 wrote: > On ...
4 years, 6 months ago (2016-06-01 01:57:04 UTC) #15
honghaiz3
https://codereview.webrtc.org/2018693002/diff/80001/webrtc/p2p/base/port.cc File webrtc/p2p/base/port.cc (right): https://codereview.webrtc.org/2018693002/diff/80001/webrtc/p2p/base/port.cc#newcode283 webrtc/p2p/base/port.cc:283: ret.first->second = conn; On 2016/05/31 20:09:29, pthatcher1 wrote: > ...
4 years, 6 months ago (2016-06-01 16:37:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018693002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018693002/180001
4 years, 6 months ago (2016-06-01 16:38:51 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 6 months ago (2016-06-01 18:39:37 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018693002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018693002/180001
4 years, 6 months ago (2016-06-01 22:55:27 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:180001)
4 years, 6 months ago (2016-06-01 22:57:07 UTC) #25
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 22:57:24 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/36f50e8e4e3e947ad8db1179e358b11431a8f079
Cr-Commit-Position: refs/heads/master@{#13000}

Powered by Google App Engine