Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2018273002: Updated #if in IsH264CodecSupported to match H264[En/De]coder::Create. (Closed)

Created:
4 years, 6 months ago by hbos
Modified:
4 years, 6 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Updated #if in IsH264CodecSupported to match H264[En/De]coder::Create. This will hopefully resolve a crash that might occur if it thinks H264 is supported when in fact it isn't. BUG=chromium:615513 Committed: https://crrev.com/073eb7ed1e398bedb8aeef1ce1bfd99f6cd0131c Cr-Commit-Position: refs/heads/master@{#12958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/video_coding/codecs/h264/h264.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hbos
Please take a look, stefan.
4 years, 6 months ago (2016-05-28 10:27:15 UTC) #2
stefan-webrtc
lgtm
4 years, 6 months ago (2016-05-30 06:34:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018273002/1
4 years, 6 months ago (2016-05-30 10:46:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 12:15:29 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 12:15:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/073eb7ed1e398bedb8aeef1ce1bfd99f6cd0131c
Cr-Commit-Position: refs/heads/master@{#12958}

Powered by Google App Engine
This is Rietveld 408576698