Reenable EndToEndTest.ReceivedFecPacketsNotNacked

Reenable EndToEndTest.ReceivedFecPacketsNotNacked
Test adjusted to be for VP8

BUG=webrtc:4328
R=pbos@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/895a2d24e9a174a11aabec35df47015fdc44cbee

[danilchap, 2016-05-26 19:07:30]

Patchset #2 (id:20001) has been deleted

[danilchap, 2016-05-27 11:15:41]

danilchap@webrtc.org changed reviewers:
+ pbos@webrtc.org

[danilchap, 2016-05-27 11:15:42]

Passed locally 3000 times in a row (before last change it fails after 60-100
runs)

[pbos-webrtc, 2016-05-27 11:53:26]

lgtm

https://codereview.webrtc.org/2017713002/diff/60001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2017713002/diff/60001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:651: // Pass one media packet after dropped
packet after last fec,
FEC

https://codereview.webrtc.org/2017713002/diff/60001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:672: nacks.begin(), nacks.end(),
fec_sequence_number_) == nacks.end());
Add a << "error message" to this explaining what went wrong.

https://codereview.webrtc.org/2017713002/diff/60001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:710: send_config->encoder_settings.payload_name
= "VP8";
For the future (if this goes flaky on DrMemory or something) we could consider
adding a fake VP8 encoder that'll produce valid headers.

[danilchap, 2016-05-27 12:11:58]

https://codereview.webrtc.org/2017713002/diff/60001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2017713002/diff/60001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:651: // Pass one media packet after dropped
packet after last fec,
On 2016/05/27 11:53:25, pbos-webrtc wrote:
> FEC

Done.

https://codereview.webrtc.org/2017713002/diff/60001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:672: nacks.begin(), nacks.end(),
fec_sequence_number_) == nacks.end());
On 2016/05/27 11:53:25, pbos-webrtc wrote:
> Add a << "error message" to this explaining what went wrong.

Done.

[commit-bot: I haz the power, 2016-05-27 12:12:23]

Description was changed from

==========
Reenable EndToEndTest.ReceivedFecPacketsNotNacked
Test adjusted to be for VP8

BUG=webrtc:4328
==========

to

==========
Reenable EndToEndTest.ReceivedFecPacketsNotNacked
Test adjusted to be for VP8

BUG=webrtc:4328
R=pbos@webrtc.org

Committed: https://crrev.com/895a2d24e9a174a11aabec35df47015fdc44cbee
Cr-Commit-Position: refs/heads/master@{#12946}
==========

[danilchap, 2016-05-27 12:12:24]

Description was changed from

==========
Reenable EndToEndTest.ReceivedFecPacketsNotNacked
Test adjusted to be for VP8

BUG=webrtc:4328
R=pbos@webrtc.org

Committed: https://crrev.com/895a2d24e9a174a11aabec35df47015fdc44cbee
Cr-Commit-Position: refs/heads/master@{#12946}
==========

to

==========
Reenable EndToEndTest.ReceivedFecPacketsNotNacked
Test adjusted to be for VP8

BUG=webrtc:4328
R=pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/895a2d24e9a174a11aabec35d...
==========

[commit-bot: I haz the power, 2016-05-27 12:12:24]

Patchset 4 (id:??) landed as
https://crrev.com/895a2d24e9a174a11aabec35df47015fdc44cbee
Cr-Commit-Position: refs/heads/master@{#12946}

[danilchap, 2016-05-27 12:12:26]

Committed patchset #4 (id:80001) manually as
895a2d24e9a174a11aabec35df47015fdc44cbee (presubmit successful).