Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Issue 2017583002: Eliminate a few uses of IsZeroSize. (Closed)

Created:
4 years, 7 months ago by nisse-webrtc
Modified:
4 years, 7 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Eliminate a few uses of IsZeroSize. BUG=webrtc:5682 Committed: https://crrev.com/97f0b93f0d8a8f6be2d60c41b984a51a921ccde4 Cr-Commit-Position: refs/heads/master@{#12923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M webrtc/video/video_quality_test.cc View 6 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
nisse-webrtc
After this, 11 uses left...
4 years, 7 months ago (2016-05-26 13:32:52 UTC) #2
pbos-webrtc
11 uses left doesn't sound like eliminating lgtm
4 years, 7 months ago (2016-05-26 13:35:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017583002/1
4 years, 7 months ago (2016-05-26 13:37:25 UTC) #6
nisse-webrtc
On 2016/05/26 13:35:00, pbos-webrtc wrote: > 11 uses left doesn't sound like eliminating > > ...
4 years, 7 months ago (2016-05-26 13:38:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-26 15:38:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017583002/1
4 years, 7 months ago (2016-05-26 15:54:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 16:44:45 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 16:44:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97f0b93f0d8a8f6be2d60c41b984a51a921ccde4
Cr-Commit-Position: refs/heads/master@{#12923}

Powered by Google App Engine
This is Rietveld 408576698