Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2017333002: Reland of Change ProcessThread's task type to be the one from TaskQueue. (Closed)

Created:
4 years, 6 months ago by tommi
Modified:
4 years, 6 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Change ProcessThread's task type to be the one from TaskQueue. (patchset #1 id:1 of https://codereview.webrtc.org/2020783003/ ) Reason for revert: Reland. It was a false alarm. Original issue's description: > Revert of Change ProcessThread's task type to be the one from TaskQueue. (patchset #3 id:80001 of https://codereview.webrtc.org/2016043003/ ) > > Reason for revert: > Downstream issues > > Original issue's description: > > Change ProcessThread's task type to be the one from TaskQueue. > > ProcessThread will eventually be replaced by TaskQueue, so this is the first little step. > > > > BUG= > > R=magjed@webrtc.org > > > > Committed: https://crrev.com/400a276c8a0b299190ff17a81edd8780a26d63d3 > > Cr-Commit-Position: refs/heads/master@{#12952} > > TBR=magjed@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= > > Committed: https://crrev.com/641455176a1241dea6dda7071ba4162f41a0b5fc > Cr-Commit-Position: refs/heads/master@{#12953} TBR=magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/435f98bc90b7cd0dd429711a67d9322443ffb122 Cr-Commit-Position: refs/heads/master@{#12954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M webrtc/modules/utility/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/utility/include/mock/mock_process_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/include/process_thread.h View 2 chunks +15 lines, -9 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M webrtc/modules/utility/utility.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tommi
Created Reland of Change ProcessThread's task type to be the one from TaskQueue.
4 years, 6 months ago (2016-05-28 21:57:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017333002/1
4 years, 6 months ago (2016-05-28 21:57:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-28 21:57:20 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 21:57:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/435f98bc90b7cd0dd429711a67d9322443ffb122
Cr-Commit-Position: refs/heads/master@{#12954}

Powered by Google App Engine
This is Rietveld 408576698