Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2016143003: Added diagnostic AEC debug logpoints. (Closed)

Created:
4 years, 6 months ago by peah-webrtc
Modified:
4 years, 6 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added diagnostic AEC debug logpoints for the purpose of simplifying offline AEC issue analysis. BUG= Committed: https://crrev.com/946f36ef397131506756cb79437940d718f5f23a Cr-Commit-Position: refs/heads/master@{#12967}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Changed acquisition of pointer to array #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 6 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
peah-webrtc
4 years, 6 months ago (2016-05-31 06:46:19 UTC) #5
hlundin-webrtc
lgtm https://codereview.webrtc.org/2016143003/diff/20001/webrtc/modules/audio_processing/aec/aec_core.cc File webrtc/modules/audio_processing/aec/aec_core.cc (right): https://codereview.webrtc.org/2016143003/diff/20001/webrtc/modules/audio_processing/aec/aec_core.cc#newcode1182 webrtc/modules/audio_processing/aec/aec_core.cc:1182: aec->data_dumper->DumpRaw("aec_nlp_gain", PART_LEN1, &hNl[0]); &hNl[0] == hNl
4 years, 6 months ago (2016-05-31 07:36:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016143003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016143003/40001
4 years, 6 months ago (2016-05-31 08:22:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-05-31 09:25:19 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 09:25:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/946f36ef397131506756cb79437940d718f5f23a
Cr-Commit-Position: refs/heads/master@{#12967}

Powered by Google App Engine
This is Rietveld 408576698