Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2016043003: Change ProcessThread's task type to be the one from TaskQueue. (Closed)

Created:
4 years, 6 months ago by tommi
Modified:
4 years, 6 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change ProcessThread's task type to be the one from TaskQueue. ProcessThread will eventually be replaced by TaskQueue, so this is the first little step. BUG= R=magjed@webrtc.org Committed: https://crrev.com/400a276c8a0b299190ff17a81edd8780a26d63d3 Cr-Commit-Position: refs/heads/master@{#12952}

Patch Set 1 #

Patch Set 2 : Work around issue with STL on Windows #

Total comments: 2

Patch Set 3 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M webrtc/modules/utility/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/utility/include/mock/mock_process_thread.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/include/process_thread.h View 1 2 chunks +15 lines, -9 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M webrtc/modules/utility/utility.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (10 generated)
tommi
4 years, 6 months ago (2016-05-27 12:02:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016043003/1
4 years, 6 months ago (2016-05-27 12:02:42 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/11542) win_rel on ...
4 years, 6 months ago (2016-05-27 12:05:56 UTC) #6
tommi
Comment out 'override' since gmock doesn't support it
4 years, 6 months ago (2016-05-27 12:16:25 UTC) #7
tommi
Comment out 'override' since gmock doesn't support it
4 years, 6 months ago (2016-05-27 12:17:51 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016043003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016043003/40001
4 years, 6 months ago (2016-05-27 12:18:17 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_compile_dbg/builds/5750) win_x64_clang_rel on ...
4 years, 6 months ago (2016-05-27 12:21:26 UTC) #12
tommi
Work around issue with STL on Windows
4 years, 6 months ago (2016-05-27 13:51:32 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016043003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016043003/60001
4 years, 6 months ago (2016-05-27 13:51:51 UTC) #15
magjed_webrtc
lgtm https://codereview.webrtc.org/2016043003/diff/60001/webrtc/modules/utility/source/process_thread_impl_unittest.cc File webrtc/modules/utility/source/process_thread_impl_unittest.cc (right): https://codereview.webrtc.org/2016043003/diff/60001/webrtc/modules/utility/source/process_thread_impl_unittest.cc#newcode40 webrtc/modules/utility/source/process_thread_impl_unittest.cc:40: bool Run() override { event_->Set(); return true; } ...
4 years, 6 months ago (2016-05-27 14:40:36 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 15:29:51 UTC) #20
tommi
Fix formatting
4 years, 6 months ago (2016-05-28 12:15:50 UTC) #21
tommi
https://codereview.webrtc.org/2016043003/diff/60001/webrtc/modules/utility/source/process_thread_impl_unittest.cc File webrtc/modules/utility/source/process_thread_impl_unittest.cc (right): https://codereview.webrtc.org/2016043003/diff/60001/webrtc/modules/utility/source/process_thread_impl_unittest.cc#newcode40 webrtc/modules/utility/source/process_thread_impl_unittest.cc:40: bool Run() override { event_->Set(); return true; } On ...
4 years, 6 months ago (2016-05-28 12:15:55 UTC) #22
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/400a276c8a0b299190ff17a81edd8780a26d63d3 Cr-Commit-Position: refs/heads/master@{#12952}
4 years, 6 months ago (2016-05-28 12:17:20 UTC) #24
tommi
4 years, 6 months ago (2016-05-28 17:02:27 UTC) #25
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.webrtc.org/2020783003/ by tommi@webrtc.org.

The reason for reverting is: Downstream issues .

Powered by Google App Engine
This is Rietveld 408576698