Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: webrtc/p2p/base/relayport_unittest.cc

Issue 2015763004: Increasing STUN timeout for some more tests. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/p2p/base/stunrequest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/relayport_unittest.cc
diff --git a/webrtc/p2p/base/relayport_unittest.cc b/webrtc/p2p/base/relayport_unittest.cc
index 738ea9abb212a7ff586d7c22da26e62c6e63d40d..8574af3a74e9f4bcf8f334513cb2b2759e7e3a1a 100644
--- a/webrtc/p2p/base/relayport_unittest.cc
+++ b/webrtc/p2p/base/relayport_unittest.cc
@@ -152,8 +152,11 @@ class RelayPortTest : public testing::Test,
EXPECT_FALSE(relay_port_->IsReady());
- // Should have timed out in 200 + 200 + 400 + 800 + 1600 ms.
- EXPECT_TRUE_WAIT(HasFailed(&fake_protocol_address), 3600);
+ // Should have timed out in 200 + 200 + 400 + 800 + 1600 ms = 3200ms.
+ // Add some margin of error for slow bots.
+ // TODO(deadbeef): Use simulated clock instead of just increasing timeouts
+ // to fix flaky tests.
+ EXPECT_TRUE_WAIT(HasFailed(&fake_protocol_address), 5000);
// Wait until relayport is ready.
EXPECT_TRUE_WAIT(relay_port_->IsReady(), kMaxTimeoutMs);
« no previous file with comments | « no previous file | webrtc/p2p/base/stunrequest_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698