Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2015763002: Making peerconnection_unittest use the virtual socket server it creates. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Making peerconnection_unittest use the virtual socket server it creates. When this test was updated to use separate worker/signaling threads, the virtual socket server wasn't moved over to the worker thread. So it was set on the signaling thread and wasn't being used. Committed: https://crrev.com/eff5b854ad54281cfef5aeecbbbeb8faebb55c97 Cr-Commit-Position: refs/heads/master@{#12951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M webrtc/api/peerconnection_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
4 years, 7 months ago (2016-05-26 00:15:41 UTC) #2
pthatcher1
lgtm
4 years, 6 months ago (2016-05-27 18:16:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015763002/1
4 years, 6 months ago (2016-05-27 20:17:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 21:18:06 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:18:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eff5b854ad54281cfef5aeecbbbeb8faebb55c97
Cr-Commit-Position: refs/heads/master@{#12951}

Powered by Google App Engine
This is Rietveld 408576698