Adds support for detection of pro-audio support on Android

Adds support for detection of pro-audio support on Android.

A new API is added which enables detection of support of pro-audio on
Android. This is part of a larger change and the new API is not used yet.
Most likely it will only be used for logging purposes.

BUG=webrtc:5925
Committed: https://crrev.com/1f0ad1085d658dc4db783a1e4280ab8d2fffc7ea
Cr-Commit-Position: refs/heads/master@{#12890}

[henrika_webrtc, 2016-05-25 09:22:20]

Description was changed from

==========
Adds support for detection of pro-audio support on Android

BUG=
==========

to

==========
Adds support for detection of pro-audio support on Android.

BUG=5925
==========

[henrika_webrtc, 2016-05-25 09:22:21]

henrika@webrtc.org changed reviewers:
+ magjed@webrtc.org

[henrika_webrtc, 2016-05-25 09:24:26]

Description was changed from

==========
Adds support for detection of pro-audio support on Android.

BUG=5925
==========

to

==========
Adds support for detection of pro-audio support on Android.

A new API is added which enables detection of support of pro-audio on
Android. This is part of a larger change and the new API is not used yet.
Most likely it will only be used for logging purposes.

BUG=5925
==========

[henrika_webrtc, 2016-05-25 09:27:09]

Magnus, PTAL

[magjed_webrtc, 2016-05-25 09:37:50]

The BUG links to some random bug, it should probably be webrtc:5925?

https://codereview.webrtc.org/2015483002/diff/20001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java
(right):

https://codereview.webrtc.org/2015483002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java:180:
return WebRtcAudioUtils.runningOnMarshmallowOrHigher() &&
nit: && should be on next line according to style guide.

https://codereview.webrtc.org/2015483002/diff/20001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java
(left):

https://codereview.webrtc.org/2015483002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java:172:
// TODO(phoglund): enable when all downstream users use M.
Are you sure this is the case?

[henrika_webrtc, 2016-05-25 10:02:19]

Description was changed from

==========
Adds support for detection of pro-audio support on Android.

A new API is added which enables detection of support of pro-audio on
Android. This is part of a larger change and the new API is not used yet.
Most likely it will only be used for logging purposes.

BUG=5925
==========

to

==========
Adds support for detection of pro-audio support on Android.

A new API is added which enables detection of support of pro-audio on
Android. This is part of a larger change and the new API is not used yet.
Most likely it will only be used for logging purposes.

BUG=webrtc:5925
==========

[henrika_webrtc, 2016-05-25 10:05:39]

Thanks. PTAL

https://codereview.webrtc.org/2015483002/diff/20001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java
(right):

https://codereview.webrtc.org/2015483002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java:180:
return WebRtcAudioUtils.runningOnMarshmallowOrHigher() &&
On 2016/05/25 09:37:50, magjed_webrtc wrote:
> nit: && should be on next line according to style guide.

Done.

https://codereview.webrtc.org/2015483002/diff/20001/webrtc/modules/audio_devi...
File
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java
(left):

https://codereview.webrtc.org/2015483002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java:172:
// TODO(phoglund): enable when all downstream users use M.
Checked with phoglund and he said Yes ;-)

[magjed_webrtc, 2016-05-25 10:58:26]

lgtm

[henrika_webrtc, 2016-05-25 11:01:57]

The CQ bit was checked by henrika@webrtc.org

[commit-bot: I haz the power, 2016-05-25 11:02:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015483002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015483002/40001

[commit-bot: I haz the power, 2016-05-25 12:15:15]

Description was changed from

==========
Adds support for detection of pro-audio support on Android.

A new API is added which enables detection of support of pro-audio on
Android. This is part of a larger change and the new API is not used yet.
Most likely it will only be used for logging purposes.

BUG=webrtc:5925
==========

to

==========
Adds support for detection of pro-audio support on Android.

A new API is added which enables detection of support of pro-audio on
Android. This is part of a larger change and the new API is not used yet.
Most likely it will only be used for logging purposes.

BUG=webrtc:5925
==========

[commit-bot: I haz the power, 2016-05-25 12:15:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-25 12:15:24]

Description was changed from

==========
Adds support for detection of pro-audio support on Android.

A new API is added which enables detection of support of pro-audio on
Android. This is part of a larger change and the new API is not used yet.
Most likely it will only be used for logging purposes.

BUG=webrtc:5925
==========

to

==========
Adds support for detection of pro-audio support on Android.

A new API is added which enables detection of support of pro-audio on
Android. This is part of a larger change and the new API is not used yet.
Most likely it will only be used for logging purposes.

BUG=webrtc:5925

Committed: https://crrev.com/1f0ad1085d658dc4db783a1e4280ab8d2fffc7ea
Cr-Commit-Position: refs/heads/master@{#12890}
==========

[commit-bot: I haz the power, 2016-05-25 12:15:25]

Patchset 3 (id:??) landed as
https://crrev.com/1f0ad1085d658dc4db783a1e4280ab8d2fffc7ea
Cr-Commit-Position: refs/heads/master@{#12890}