Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2014823002: Reduce flakiness in IvfFileWriter tests. (Closed)

Created:
4 years, 7 months ago by sprang_webrtc
Modified:
4 years, 7 months ago
Reviewers:
sprang, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reduce flakiness in IvfFileWriter tests. If deleting files fails, wait a sec and retry. This can help in case and antivirus software or similar has locked the file, preventing it from being deleted. BUG=webrtc:5898 Committed: https://crrev.com/73257d1b5a281ed76f553940f16546c59a4207b9 Cr-Commit-Position: refs/heads/master@{#12917}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc View 5 chunks +34 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sprang_webrtc
4 years, 7 months ago (2016-05-26 09:14:13 UTC) #2
pbos-webrtc
eew, lgtm
4 years, 7 months ago (2016-05-26 11:37:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014823002/1
4 years, 7 months ago (2016-05-26 12:34:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 12:45:56 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 12:46:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73257d1b5a281ed76f553940f16546c59a4207b9
Cr-Commit-Position: refs/heads/master@{#12917}

Powered by Google App Engine
This is Rietveld 408576698