Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2013403002: Start integrating StatsCounter class. (Closed)

Created:
4 years, 6 months ago by åsapersson
Modified:
4 years, 6 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Start integrating StatsCounter class. SampleCounter replaced with AvgCounter for metric WebRTC.Video.SendDelayInMs (removes duplicated code of SampleCounter). BUG=webrtc:5283 Committed: https://crrev.com/40f54003d695957729e34ee1e643f6ad3837b8f2 Cr-Commit-Position: refs/heads/master@{#13081}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -33 lines) Patch
M webrtc/video/send_delay_stats.h View 1 3 chunks +7 lines, -14 lines 0 comments Download
M webrtc/video/send_delay_stats.cc View 1 5 chunks +15 lines, -16 lines 0 comments Download
M webrtc/video/send_delay_stats_unittest.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
åsapersson
4 years, 6 months ago (2016-05-30 12:20:44 UTC) #9
stefan-webrtc
lgtm
4 years, 6 months ago (2016-06-08 11:14:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013403002/120001
4 years, 6 months ago (2016-06-09 06:50:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 6 months ago (2016-06-09 07:09:27 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 07:09:33 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40f54003d695957729e34ee1e643f6ad3837b8f2
Cr-Commit-Position: refs/heads/master@{#13081}

Powered by Google App Engine
This is Rietveld 408576698