VideoCapturerAndroid: Replace static create() with ctor

VideoCapturerAndroid: Replace static create() with ctor

This CL makes the ctor public and externally usable by changing the
camera id argument from an int to a String.

The main purpose with this change is to get rid of the
CameraEnumerationAndroid.setEnumerator() hack. If an external app wants
to have a custom format enumeration, they can just override
getSupportedFormats() instead.

BUG=webrtc:5519
Committed: https://crrev.com/36c11e9132b61658ee8704e23ab0c66b50a9c1b1
Cr-Commit-Position: refs/heads/master@{#12945}

[magjed_webrtc, 2016-05-26 14:05:32]

Description was changed from

==========
VideoCapturerAndroid: Replace static create() with ctor

This CL makes the ctor public and externally usable by changing the
camera id argument from an int to a String, just like the create()
function.

The main purpose with this change is to get rid of the
CameraEnumerationAndroid.setEnumerator() hack. If an external app wants
to make a custom format enumeration, they can just override
getSupportedFormats() instead.

BUG=webrtc:5519
==========

to

==========
VideoCapturerAndroid: Replace static create() with ctor

This CL makes the ctor public and externally usable by changing the
camera id argument from an int to a String.

The main purpose with this change is to get rid of the
CameraEnumerationAndroid.setEnumerator() hack. If an external app wants
to make a custom format enumeration, they can just override
getSupportedFormats() instead.

BUG=webrtc:5519
==========

[magjed_webrtc, 2016-05-26 14:05:57]

Description was changed from

==========
VideoCapturerAndroid: Replace static create() with ctor

This CL makes the ctor public and externally usable by changing the
camera id argument from an int to a String.

The main purpose with this change is to get rid of the
CameraEnumerationAndroid.setEnumerator() hack. If an external app wants
to make a custom format enumeration, they can just override
getSupportedFormats() instead.

BUG=webrtc:5519
==========

to

==========
VideoCapturerAndroid: Replace static create() with ctor

This CL makes the ctor public and externally usable by changing the
camera id argument from an int to a String.

The main purpose with this change is to get rid of the
CameraEnumerationAndroid.setEnumerator() hack. If an external app wants
to have a custom format enumeration, they can just override
getSupportedFormats() instead.

BUG=webrtc:5519
==========

[magjed_webrtc, 2016-05-26 14:07:13]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2016-05-26 14:07:29]

Sami - please take a look.

[sakal, 2016-05-26 14:20:22]

https://codereview.webrtc.org/2012193003/diff/1/webrtc/api/java/android/org/w...
File webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/2012193003/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:108: // Depreated.
Use ctor directly instead.
Nit: Deprecated

Also, should we add the @Deprecated annotation?

[magjed_webrtc, 2016-05-26 14:58:07]

https://codereview.webrtc.org/2012193003/diff/1/webrtc/api/java/android/org/w...
File webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/2012193003/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:108: // Depreated.
Use ctor directly instead.
On 2016/05/26 14:20:22, sakal wrote:
> Nit: Deprecated
> 
> Also, should we add the @Deprecated annotation?

Yes, it's probably a good idea.

[sakal, 2016-05-27 07:18:51]

On 2016/05/26 14:58:07, magjed_webrtc wrote:
>
https://codereview.webrtc.org/2012193003/diff/1/webrtc/api/java/android/org/w...
> File webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java (right):
> 
>
https://codereview.webrtc.org/2012193003/diff/1/webrtc/api/java/android/org/w...
> webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:108: //
Depreated.
> Use ctor directly instead.
> On 2016/05/26 14:20:22, sakal wrote:
> > Nit: Deprecated
> > 
> > Also, should we add the @Deprecated annotation?
> 
> Yes, it's probably a good idea.

lgtm

[magjed_webrtc, 2016-05-27 08:32:02]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-05-27 08:32:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012193003/20001

[commit-bot: I haz the power, 2016-05-27 09:35:13]

Description was changed from

==========
VideoCapturerAndroid: Replace static create() with ctor

This CL makes the ctor public and externally usable by changing the
camera id argument from an int to a String.

The main purpose with this change is to get rid of the
CameraEnumerationAndroid.setEnumerator() hack. If an external app wants
to have a custom format enumeration, they can just override
getSupportedFormats() instead.

BUG=webrtc:5519
==========

to

==========
VideoCapturerAndroid: Replace static create() with ctor

This CL makes the ctor public and externally usable by changing the
camera id argument from an int to a String.

The main purpose with this change is to get rid of the
CameraEnumerationAndroid.setEnumerator() hack. If an external app wants
to have a custom format enumeration, they can just override
getSupportedFormats() instead.

BUG=webrtc:5519
==========

[commit-bot: I haz the power, 2016-05-27 09:35:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-27 09:35:22]

Description was changed from

==========
VideoCapturerAndroid: Replace static create() with ctor

This CL makes the ctor public and externally usable by changing the
camera id argument from an int to a String.

The main purpose with this change is to get rid of the
CameraEnumerationAndroid.setEnumerator() hack. If an external app wants
to have a custom format enumeration, they can just override
getSupportedFormats() instead.

BUG=webrtc:5519
==========

to

==========
VideoCapturerAndroid: Replace static create() with ctor

This CL makes the ctor public and externally usable by changing the
camera id argument from an int to a String.

The main purpose with this change is to get rid of the
CameraEnumerationAndroid.setEnumerator() hack. If an external app wants
to have a custom format enumeration, they can just override
getSupportedFormats() instead.

BUG=webrtc:5519

Committed: https://crrev.com/36c11e9132b61658ee8704e23ab0c66b50a9c1b1
Cr-Commit-Position: refs/heads/master@{#12945}
==========

[commit-bot: I haz the power, 2016-05-27 09:35:23]

Patchset 2 (id:??) landed as
https://crrev.com/36c11e9132b61658ee8704e23ab0c66b50a9c1b1
Cr-Commit-Position: refs/heads/master@{#12945}