Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2011503002: Remove unused libjingle_xmpphelp target. (Closed)

Created:
4 years, 7 months ago by tommi
Modified:
4 years, 7 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused libjingle_xmpphelp target. NOTRY=true Committed: https://crrev.com/1b32acdbd01c28bf02fecff84992aa30c252677e Cr-Commit-Position: refs/heads/master@{#12877}

Patch Set 1 #

Patch Set 2 : Also remove autoportallocator.h, which seems to be orphaned, yet references the task type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -248 lines) Patch
D webrtc/libjingle/libjingle.gyp View 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/libjingle/xmpp/jingleinfotask.h View 1 chunk +0 lines, -44 lines 0 comments Download
D webrtc/libjingle/xmpp/jingleinfotask.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D webrtc/p2p/client/autoportallocator.h View 1 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
tommi
4 years, 7 months ago (2016-05-24 14:12:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011503002/1
4 years, 7 months ago (2016-05-24 14:13:00 UTC) #4
tommi
Also remove autoportallocator.h, which seems to be orphaned, yet references the task type
4 years, 7 months ago (2016-05-24 14:17:22 UTC) #5
kjellander_webrtc
Please please don't run the CQ trybots for CLs like this, we don't have the ...
4 years, 7 months ago (2016-05-24 15:11:05 UTC) #6
tommi
On 2016/05/24 15:11:05, kjellander (webrtc) wrote: > Please please don't run the CQ trybots for ...
4 years, 7 months ago (2016-05-24 18:28:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011503002/20001
4 years, 7 months ago (2016-05-24 18:28:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 18:33:38 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1b32acdbd01c28bf02fecff84992aa30c252677e Cr-Commit-Position: refs/heads/master@{#12877}
4 years, 7 months ago (2016-05-24 18:33:46 UTC) #14
kjellander_webrtc
4 years, 7 months ago (2016-05-25 05:28:21 UTC) #15
Message was sent while issue was closed.
On 2016/05/24 18:28:01, tommi-webrtc wrote:
> On 2016/05/24 15:11:05, kjellander (webrtc) wrote:
> > Please please don't run the CQ trybots for CLs like this, we don't have the
> > resources of queuing up the Android testers for compile-only changes.
> Hand-pick
> > a few and then either add NOTRY=True or commit manually.
> > 
> > lgtm
> 
> The intention was to have the cl ready for the cq.

Right, but we don't need to run the CQ for CLs that obviously cannot affect any
tests. Our bots are just too slow to catch up with the load for that.
I'd love to work on speeding this up with swarming, but I still haven't reached
that on my prio list.

Powered by Google App Engine
This is Rietveld 408576698