Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2011433002: Properly wire up the event log to the VideoSendStream. (Closed)

Created:
4 years, 7 months ago by terelius
Modified:
4 years, 7 months ago
Reviewers:
ivoc, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Properly wire up the event log to the VideoSendStream. Also set the Configuration parameters in CreateRtpRtcpModules in the same order as the members are declared. BUG=webrtc:5917 Committed: https://crrev.com/adafe0b70aefd5fa312b3b9f3455acfcb7b076f4 Cr-Commit-Position: refs/heads/master@{#12905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M webrtc/call/call.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 5 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
terelius
PTAL
4 years, 7 months ago (2016-05-24 16:03:08 UTC) #2
pbos-webrtc
lgtm, please have ivoc@ review it also since he knows what the fuzz is about.
4 years, 7 months ago (2016-05-25 15:47:09 UTC) #3
ivoc
LGTM.
4 years, 7 months ago (2016-05-26 07:35:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011433002/1
4 years, 7 months ago (2016-05-26 07:55:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 08:58:44 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 08:58:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adafe0b70aefd5fa312b3b9f3455acfcb7b076f4
Cr-Commit-Position: refs/heads/master@{#12905}

Powered by Google App Engine
This is Rietveld 408576698