Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2009833003: iOS: Move JSON bot configurations after promoting GN bots. (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Move JSON bot configurations after promoting GN bots. BUG=webrtc:5586 TBR=phoglund@webrtc.org Committed: https://crrev.com/3b32236f220d393f5fc2d92a6b6e23fd3f04fe2e Cr-Commit-Position: refs/heads/master@{#12908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -46 lines) Patch
D webrtc/build/ios/client.webrtc.fyi/iOS64_Debug_(GN).json View 1 chunk +0 lines, -24 lines 0 comments Download
D webrtc/build/ios/client.webrtc.fyi/iOS64_Release_(GN).json View 1 chunk +0 lines, -24 lines 0 comments Download
A + webrtc/build/ios/client.webrtc/iOS64_Debug_(GN).json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/build/ios/client.webrtc/iOS64_Release_(GN).json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
Oh dear, so many places with configs...
4 years, 7 months ago (2016-05-26 09:23:05 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b32236f220d393f5fc2d92a6b6e23fd3f04fe2e Cr-Commit-Position: refs/heads/master@{#12908}
4 years, 7 months ago (2016-05-26 09:23:37 UTC) #4
kjellander_webrtc
Committed patchset #1 (id:1) manually as 3b32236f220d393f5fc2d92a6b6e23fd3f04fe2e (presubmit successful).
4 years, 7 months ago (2016-05-26 09:23:38 UTC) #5
phoglund
4 years, 7 months ago (2016-05-26 12:05:35 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698