Making ECDSA the default certificate regardless of WEBRTC_CHROMIUM_BUILD.

Making ECDSA the default certificate regardless of WEBRTC_CHROMIUM_BUILD.

Due to the experiment in chromium relying on KT_DEFAULT = KT_RSA (bug:
crbug.com/611698) a conditional was introduced. Now that the experiment is
ending and the experiment flag has been removed we can make KT_DEFAULT=KT_ECDSA
unconditionally.

BUG=chromium:611698
Committed: https://crrev.com/41c5cd02fc7eb9601edb317b21b3d07bdaafbc37
Cr-Commit-Position: refs/heads/master@{#12935}

[hbos, 2016-05-24 17:27:45]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 17:27:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009533003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009533003/1

[hbos, 2016-05-24 17:36:41]

hbos@webrtc.org changed reviewers:
+ tommi@webrtc.org

[hbos, 2016-05-24 17:36:41]

Please take a look, tommi.

(Note that the statement "the experiment flag has been removed" is only true
after this CL lands: https://codereview.chromium.org/2011443002/)

[tommi, 2016-05-24 18:20:23]

lgtm % formatting question

https://codereview.webrtc.org/2009533003/diff/1/webrtc/base/sslidentity.h
File webrtc/base/sslidentity.h (right):

https://codereview.webrtc.org/2009533003/diff/1/webrtc/base/sslidentity.h#new...
webrtc/base/sslidentity.h:120: enum KeyType { KT_RSA, KT_ECDSA, KT_LAST,
KT_DEFAULT = KT_ECDSA };
did you run git cl format?

[hbos, 2016-05-24 18:43:11]

https://codereview.webrtc.org/2009533003/diff/1/webrtc/base/sslidentity.h
File webrtc/base/sslidentity.h (right):

https://codereview.webrtc.org/2009533003/diff/1/webrtc/base/sslidentity.h#new...
webrtc/base/sslidentity.h:120: enum KeyType { KT_RSA, KT_ECDSA, KT_LAST,
KT_DEFAULT = KT_ECDSA };
On 2016/05/24 18:20:23, tommi-webrtc wrote:
> did you run git cl format?

If I run it it does not change the code, so I guess it approves. I made it one
line because I remember it was one line before I did my #if change.

[commit-bot: I haz the power, 2016-05-24 19:28:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 19:28:10]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tommi, 2016-05-24 20:40:16]

On 2016/05/24 18:43:11, hbos wrote:
> https://codereview.webrtc.org/2009533003/diff/1/webrtc/base/sslidentity.h
> File webrtc/base/sslidentity.h (right):
> 
>
https://codereview.webrtc.org/2009533003/diff/1/webrtc/base/sslidentity.h#new...
> webrtc/base/sslidentity.h:120: enum KeyType { KT_RSA, KT_ECDSA, KT_LAST,
> KT_DEFAULT = KT_ECDSA };
> On 2016/05/24 18:20:23, tommi-webrtc wrote:
> > did you run git cl format?
> 
> If I run it it does not change the code, so I guess it approves. I made it one
> line because I remember it was one line before I did my #if change.

ok, lgtm

[hbos, 2016-05-26 18:06:13]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-05-26 18:06:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009533003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009533003/1

[commit-bot: I haz the power, 2016-05-26 20:06:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 20:06:42]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[hbos, 2016-05-26 22:21:30]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-05-26 22:21:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009533003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009533003/1

[commit-bot: I haz the power, 2016-05-26 22:23:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-26 22:23:24]

Description was changed from

==========
Making ECDSA the default certificate regardless of WEBRTC_CHROMIUM_BUILD.

Due to the experiment in chromium relying on KT_DEFAULT = KT_RSA (bug:
crbug.com/611698) a conditional was introduced. Now that the experiment is
ending and the experiment flag has been removed we can make KT_DEFAULT=KT_ECDSA
unconditionally.

BUG=chromium:611698
==========

to

==========
Making ECDSA the default certificate regardless of WEBRTC_CHROMIUM_BUILD.

Due to the experiment in chromium relying on KT_DEFAULT = KT_RSA (bug:
crbug.com/611698) a conditional was introduced. Now that the experiment is
ending and the experiment flag has been removed we can make KT_DEFAULT=KT_ECDSA
unconditionally.

BUG=chromium:611698

Committed: https://crrev.com/41c5cd02fc7eb9601edb317b21b3d07bdaafbc37
Cr-Commit-Position: refs/heads/master@{#12935}
==========

[commit-bot: I haz the power, 2016-05-26 22:23:25]

Patchset 1 (id:??) landed as
https://crrev.com/41c5cd02fc7eb9601edb317b21b3d07bdaafbc37
Cr-Commit-Position: refs/heads/master@{#12935}