Improve IP_PATTERN in DirectRTCClient in Android AppRTC Demo

Improve IP_PATTERN in DirectRTCClient in Android AppRTC Demo

Earlier, strings like "aaaa" and "1111" would be interpreted as IP
addresses, which is not optimal. This CL improves the IP_PATTERN and
adds a test for it.

Committed: https://crrev.com/b0cf1a89168620f7490a375056059c6f84b05081
Cr-Commit-Position: refs/heads/master@{#12887}

[sakal, 2016-05-24 11:59:13]

Description was changed from

==========
Improve IP_PATTERN in DirectRTCClient in Android AppRTC Demo

Earlier, strings like "aaaa" and "1111" would be interpreted as IP
addresses, which is not optimal. This CL improves the IP_PATTERN and
adds a test for it.
==========

to

==========
Improve IP_PATTERN in DirectRTCClient in Android AppRTC Demo

Earlier, strings like "aaaa" and "1111" would be interpreted as IP
addresses, which is not optimal. This CL improves the IP_PATTERN and
adds a test for it.
==========

[sakal, 2016-05-24 11:59:13]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2016-05-24 11:59:38]

Magnus, please take a look.

[magjed_webrtc, 2016-05-24 14:08:23]

https://codereview.webrtc.org/2009493002/diff/1/webrtc/examples/androidjunit/...
File
webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java
(right):

https://codereview.webrtc.org/2009493002/diff/1/webrtc/examples/androidjunit/...
webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java:63:
public void testIpPattern() {
Split up in two tests testValidIpPattern()/testInvalidIpPattern() and use
assertTrue(ip + " didn't match IP_PATTERN",
DirectRTCClient.IP_PATTERN.matcher(ip).matches()) instead of fail().

[sakal, 2016-05-24 14:17:48]

https://codereview.webrtc.org/2009493002/diff/1/webrtc/examples/androidjunit/...
File
webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java
(right):

https://codereview.webrtc.org/2009493002/diff/1/webrtc/examples/androidjunit/...
webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java:63:
public void testIpPattern() {
On 2016/05/24 14:08:23, magjed_webrtc wrote:
> Split up in two tests testValidIpPattern()/testInvalidIpPattern() and use
> assertTrue(ip + " didn't match IP_PATTERN",
> DirectRTCClient.IP_PATTERN.matcher(ip).matches()) instead of fail().

Done.

[magjed_webrtc, 2016-05-25 09:24:44]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-05-25 09:24:45]

lgtm

[commit-bot: I haz the power, 2016-05-25 09:24:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009493002/20001

[commit-bot: I haz the power, 2016-05-25 09:26:27]

Description was changed from

==========
Improve IP_PATTERN in DirectRTCClient in Android AppRTC Demo

Earlier, strings like "aaaa" and "1111" would be interpreted as IP
addresses, which is not optimal. This CL improves the IP_PATTERN and
adds a test for it.
==========

to

==========
Improve IP_PATTERN in DirectRTCClient in Android AppRTC Demo

Earlier, strings like "aaaa" and "1111" would be interpreted as IP
addresses, which is not optimal. This CL improves the IP_PATTERN and
adds a test for it.
==========

[commit-bot: I haz the power, 2016-05-25 09:26:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-25 09:26:34]

Description was changed from

==========
Improve IP_PATTERN in DirectRTCClient in Android AppRTC Demo

Earlier, strings like "aaaa" and "1111" would be interpreted as IP
addresses, which is not optimal. This CL improves the IP_PATTERN and
adds a test for it.
==========

to

==========
Improve IP_PATTERN in DirectRTCClient in Android AppRTC Demo

Earlier, strings like "aaaa" and "1111" would be interpreted as IP
addresses, which is not optimal. This CL improves the IP_PATTERN and
adds a test for it.

Committed: https://crrev.com/b0cf1a89168620f7490a375056059c6f84b05081
Cr-Commit-Position: refs/heads/master@{#12887}
==========

[commit-bot: I haz the power, 2016-05-25 09:26:35]

Patchset 2 (id:??) landed as
https://crrev.com/b0cf1a89168620f7490a375056059c6f84b05081
Cr-Commit-Position: refs/heads/master@{#12887}