Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: webrtc/common_video/i420_buffer_pool_unittest.cc

Issue 2009193002: Delete IsMutable and IsExclusive methods. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Delete redundant RefCountedObject wrapping. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/common_video/i420_buffer_pool.cc ('k') | webrtc/common_video/i420_video_frame_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_video/i420_buffer_pool_unittest.cc
diff --git a/webrtc/common_video/i420_buffer_pool_unittest.cc b/webrtc/common_video/i420_buffer_pool_unittest.cc
index 2110066a928d7e10ce8171bf78d8c6e76d55232b..3e795dbdc4b3f021ca77ef3122b570bb843a5172 100644
--- a/webrtc/common_video/i420_buffer_pool_unittest.cc
+++ b/webrtc/common_video/i420_buffer_pool_unittest.cc
@@ -51,20 +51,12 @@ TEST(TestI420BufferPool, FailToReuse) {
EXPECT_NE(v_ptr, buffer->DataV());
}
-TEST(TestI420BufferPool, ExclusiveOwner) {
- // Check that created buffers are exclusive so that they can be written to.
- I420BufferPool pool;
- rtc::scoped_refptr<VideoFrameBuffer> buffer = pool.CreateBuffer(16, 16);
- EXPECT_TRUE(buffer->IsMutable());
-}
-
TEST(TestI420BufferPool, FrameValidAfterPoolDestruction) {
rtc::scoped_refptr<VideoFrameBuffer> buffer;
{
I420BufferPool pool;
buffer = pool.CreateBuffer(16, 16);
}
- EXPECT_TRUE(buffer->IsMutable());
EXPECT_EQ(16, buffer->width());
EXPECT_EQ(16, buffer->height());
// Try to trigger use-after-free errors by writing to y-plane.
« no previous file with comments | « webrtc/common_video/i420_buffer_pool.cc ('k') | webrtc/common_video/i420_video_frame_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698