Delete IsMutable and IsExclusive methods.

webrtc/common_video/video_frame.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 48 matching lines @@
   RTC_DCHECK_GE(stride_y, width);
   RTC_DCHECK_GE(stride_u, half_width);
   RTC_DCHECK_GE(stride_v, half_width);
 
   // Creating empty frame - reset all values.
   timestamp_ = 0;
   ntp_time_ms_ = 0;
   render_time_ms_ = 0;
   rotation_ = kVideoRotation_0;
 
-  // Check if it's safe to reuse allocation.
-  if (video_frame_buffer_ && video_frame_buffer_->IsMutable() &&
-      !video_frame_buffer_->native_handle() &&
-      width == video_frame_buffer_->width() &&
-      height == video_frame_buffer_->height() &&
-      stride_y == video_frame_buffer_->StrideY() &&
-      stride_u == video_frame_buffer_->StrideU() &&
-      stride_v == video_frame_buffer_->StrideV()) {
-    return;
-  }
-
-  // Need to allocate new buffer.
+  // Allocate a new buffer.

[pbos-webrtc, 2016/05/25 15:26:07]

Should this check if video_frame_buffer_->HasOneRef() instead of IsMutable? Is
this method called often or going away?

[nisse-webrtc, 2016/05/26 07:44:42]

It was used by the frame factory, that's why I changed it to make it use a
buffer pool instead. Besides that, the method is used only by test code.

And both HasOneRef and IsMutable are being purged from the public interface. (If
you want to keep one, IsMutable is the better name, imo).

   video_frame_buffer_ = new rtc::RefCountedObject<I420Buffer>(
       width, height, stride_y, stride_u, stride_v);
 }
 
 void VideoFrame::CreateFrame(const uint8_t* buffer_y,
                              const uint8_t* buffer_u,
                              const uint8_t* buffer_v,
                              int width,
                              int height,
                              int stride_y,
@@ skipping 107 matching lines @@
     case kVideoCodecULPFEC:
     case kVideoCodecGeneric:
     case kVideoCodecUnknown:
       return 0;
   }
   RTC_NOTREACHED();
   return 0;
 }
 
 }  // namespace webrtc