Forward Encode failure codes from sub encoders.

Forward Encode failure codes from sub encoders.

Previously, failure codes were ignored, which meant simulcasted codecs
couldn't e.g. trigger software fallback. This stops the simulcasted
Encode call at the first faiulre and returns that code.

Another option is to continue sending the frame to the other encoders
but still return the first failure code. It's not clear that that is any
better than just quitting as soon as a failure happens.

BUG=

Committed: https://crrev.com/57779104f0b7b5cb6b4e6eb33eb3267cb9f4d423
Cr-Commit-Position: refs/heads/master@{#12892}

[noahric, 2016-05-23 21:42:30]

noahric@chromium.org changed reviewers:
+ mflodman@webrtc.org, pbos@webrtc.org

[pbos-webrtc, 2016-05-23 21:50:14]

On 2016/05/23 21:42:31, noahric wrote:

Can you write a test that verifies that we forward the correct error code?

This would go in:
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

[noahric, 2016-05-23 22:33:28]

On 2016/05/23 21:50:14, pbos-webrtc wrote:
> On 2016/05/23 21:42:31, noahric wrote:
> 
> Can you write a test that verifies that we forward the correct error code?
> 
> This would go in:
> webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

Added test. Also switched to using NiceMock for the encoder, so there aren't a
million warnings about ImplementationName.

[pbos-webrtc, 2016-05-24 13:26:33]

lgtm with nit fixed

https://codereview.webrtc.org/2008723002/diff/40001/webrtc/modules/video_codi...
File
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
(right):

https://codereview.webrtc.org/2008723002/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc:477:
encoder->set_encode_return_value(WEBRTC_VIDEO_CODEC_FALLBACK_SOFTWARE);
Set only one of them (like encoders()[1]) to make sure that one failing is
enough.

[noahric, 2016-05-24 18:31:09]

https://codereview.webrtc.org/2008723002/diff/40001/webrtc/modules/video_codi...
File
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
(right):

https://codereview.webrtc.org/2008723002/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc:477:
encoder->set_encode_return_value(WEBRTC_VIDEO_CODEC_FALLBACK_SOFTWARE);
On 2016/05/24 13:26:33, pbos-webrtc wrote:
> Set only one of them (like encoders()[1]) to make sure that one failing is
> enough.

Done.

[noahric, 2016-05-24 21:14:50]

The CQ bit was checked by noahric@chromium.org

[noahric, 2016-05-24 21:14:51]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2008723002/#ps60001 (title:
"Test: only set software fallback on 2nd encoder.")

[commit-bot: I haz the power, 2016-05-24 21:14:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008723002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008723002/60001

[commit-bot: I haz the power, 2016-05-24 23:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 23:15:19]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[pbos-webrtc, 2016-05-25 13:47:08]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2016-05-25 13:47:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008723002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008723002/60001

[commit-bot: I haz the power, 2016-05-25 13:48:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-25 13:49:00]

Description was changed from

==========
Forward Encode failure codes from sub encoders.

Previously, failure codes were ignored, which meant simulcasted codecs
couldn't e.g. trigger software fallback. This stops the simulcasted
Encode call at the first faiulre and returns that code.

Another option is to continue sending the frame to the other encoders
but still return the first failure code. It's not clear that that is any
better than just quitting as soon as a failure happens.

BUG=
==========

to

==========
Forward Encode failure codes from sub encoders.

Previously, failure codes were ignored, which meant simulcasted codecs
couldn't e.g. trigger software fallback. This stops the simulcasted
Encode call at the first faiulre and returns that code.

Another option is to continue sending the frame to the other encoders
but still return the first failure code. It's not clear that that is any
better than just quitting as soon as a failure happens.

BUG=

Committed: https://crrev.com/57779104f0b7b5cb6b4e6eb33eb3267cb9f4d423
Cr-Commit-Position: refs/heads/master@{#12892}
==========

[commit-bot: I haz the power, 2016-05-25 13:49:01]

Patchset 4 (id:??) landed as
https://crrev.com/57779104f0b7b5cb6b4e6eb33eb3267cb9f4d423
Cr-Commit-Position: refs/heads/master@{#12892}