Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2008693002: iOS: Replace find with actual filenames listed. (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, dierksen_google.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Replace find with actual filenames listed. Some build tools downstream breaks since find on Linux doesn't support the -E flag. Shell commands also shouldn't be executed as part of GYP unless there's no other way around the problem. NOTRY=True Committed: https://crrev.com/7e9274638e35ceda1f836be74fb7a9b128033d78 Cr-Commit-Position: refs/heads/master@{#12858}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sorted the list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M webrtc/sdk/sdk.gyp View 1 1 chunk +34 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_webrtc
4 years, 7 months ago (2016-05-23 21:25:54 UTC) #2
tkchin_webrtc
lgtm https://codereview.webrtc.org/2008693002/diff/1/webrtc/sdk/sdk.gyp File webrtc/sdk/sdk.gyp (right): https://codereview.webrtc.org/2008693002/diff/1/webrtc/sdk/sdk.gyp#newcode229 webrtc/sdk/sdk.gyp:229: 'objc/Framework/Headers/WebRTC/WebRTC.h', alphabetize
4 years, 7 months ago (2016-05-23 21:28:08 UTC) #4
kjellander_webrtc
https://codereview.webrtc.org/2008693002/diff/1/webrtc/sdk/sdk.gyp File webrtc/sdk/sdk.gyp (right): https://codereview.webrtc.org/2008693002/diff/1/webrtc/sdk/sdk.gyp#newcode229 webrtc/sdk/sdk.gyp:229: 'objc/Framework/Headers/WebRTC/WebRTC.h', On 2016/05/23 21:28:08, tkchin_webrtc wrote: > alphabetize Done.
4 years, 7 months ago (2016-05-24 05:11:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008693002/20001
4 years, 7 months ago (2016-05-24 05:12:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 05:13:49 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 05:13:57 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e9274638e35ceda1f836be74fb7a9b128033d78
Cr-Commit-Position: refs/heads/master@{#12858}

Powered by Google App Engine
This is Rietveld 408576698