Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2008483002: Adjust max number of samples that can be stored for a histogram (2000->300). (Closed)

Created:
4 years, 7 months ago by åsapersson
Modified:
4 years, 7 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adjust max number of samples that can be stored for a histogram (2000->300). Consider follow up and use actual bucket count when storing samples. BUG= Committed: https://crrev.com/7d5699789434888064fe4e544b7af5ceee21c177 Cr-Commit-Position: refs/heads/master@{#12872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/system_wrappers/source/metrics_default.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
åsapersson
4 years, 7 months ago (2016-05-23 14:47:51 UTC) #3
mflodman
LGTM Any specific reasons for setting this to a lower number? And will this be ...
4 years, 7 months ago (2016-05-23 17:51:55 UTC) #4
åsapersson
On 2016/05/23 17:51:55, mflodman wrote: > LGTM > > Any specific reasons for setting this ...
4 years, 7 months ago (2016-05-24 12:04:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008483002/1
4 years, 7 months ago (2016-05-24 12:05:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 13:03:41 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 13:03:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d5699789434888064fe4e544b7af5ceee21c177
Cr-Commit-Position: refs/heads/master@{#12872}

Powered by Google App Engine
This is Rietveld 408576698