Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2007883002: Remove xmllite and xmpp dependencies from merge_libs.gyp. (Closed)

Created:
4 years, 7 months ago by tommi
Modified:
4 years, 7 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove xmllite and xmpp dependencies from merge_libs.gyp. I looked around and couldn't find any use of these dependencies. NOTRY=true (setting NOTRY since merge_libs.gyp isn't actually referenced by any gyp file, it's only used downstream) Committed: https://crrev.com/48831cd8a486e8af45f29a999136a13f75e5af7d Cr-Commit-Position: refs/heads/master@{#12868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/build/merge_libs.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tommi
4 years, 7 months ago (2016-05-24 10:03:16 UTC) #2
phoglund
lgtm
4 years, 7 months ago (2016-05-24 11:10:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007883002/1
4 years, 7 months ago (2016-05-24 12:44:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 12:46:21 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 12:46:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48831cd8a486e8af45f29a999136a13f75e5af7d
Cr-Commit-Position: refs/heads/master@{#12868}

Powered by Google App Engine
This is Rietveld 408576698