Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2007863005: VideoCapturerAndroid: Remove isDisposed() (Closed)

Created:
4 years, 7 months ago by magjed_webrtc
Modified:
4 years, 7 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid: Remove isDisposed() Also remove the unnecessary code in VideoCapturerAndroid.dispose() and only log instead. BUG=webrtc:5519 Committed: https://crrev.com/cd8e2ba29b0e22125da3e86b5579e6ba2b2efa35 Cr-Commit-Position: refs/heads/master@{#12913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTestFixtures.java View 6 chunks +0 lines, -6 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 2 chunks +1 line, -18 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
magjed_webrtc
Sami - Please take a look.
4 years, 7 months ago (2016-05-26 10:01:47 UTC) #3
sakal
On 2016/05/26 10:01:47, magjed_webrtc wrote: > Sami - Please take a look. lgtm
4 years, 7 months ago (2016-05-26 10:23:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007863005/1
4 years, 7 months ago (2016-05-26 10:29:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 11:00:53 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 11:01:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd8e2ba29b0e22125da3e86b5579e6ba2b2efa35
Cr-Commit-Position: refs/heads/master@{#12913}

Powered by Google App Engine
This is Rietveld 408576698