webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc - Issue 2007743003: Add sender controlled playout delay limits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc

Issue 2007743003: Add sender controlled playout delay limits (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@cleanup_rtp_hdr_extensions

Patch Set: Addressed comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/playout_delay_oracle.cc ('K') | « webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_sender.h » ('j') | webrtc/modules/rtp_rtcp/source/rtp_sender.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc

index 7e0ac312c804df4cb4a0c67e135ed7c1f4397b93..86df1838c0f4d6c1b622d35f712102d574506e1c 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc

@@ -194,14 +194,11 @@ class RtpRtcpImplTest : public ::testing::Test {

void SendFrame(const RtpRtcpModule* module, uint8_t tid) {

RTPVideoHeaderVP8 vp8_header = {};

+ PlayoutDelay playout_delay = {-1, -1};

vp8_header.temporalIdx = tid;

- RTPVideoHeader rtp_video_header = {codec_.width,

- codec_.height,

- kVideoRotation_0,

- true,

- 0,

- kRtpVideoVp8,

- {vp8_header}};

+ RTPVideoHeader rtp_video_header = {

+ codec_.width, codec_.height, kVideoRotation_0, {playout_delay}, true, 0,

+ kRtpVideoVp8, {vp8_header}};

const uint8_t payload[100] = {0};

EXPECT_EQ(0, module->impl_->SendOutgoingData(kVideoFrameKey,