Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/playout_delay_oracle_unittest.cc

Issue 2007743003: Add sender controlled playout delay limits (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@cleanup_rtp_hdr_extensions
Patch Set: Remove notion of max and current header length Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #include "webrtc/modules/rtp_rtcp/source/playout_delay_oracle.h"
12
13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "webrtc/base/logging.h"
15
16 namespace webrtc {
17
18 namespace {
19 constexpr int kSsrc = 100;
20 constexpr int kSequenceNumber = 100;
21 constexpr int kMinPlayoutDelay = 0;
22 constexpr int kMaxPlayoutDelay = 150;
23 } // namespace
24
25 class PlayoutDelayOracleTest : public ::testing::Test {
26 protected:
27 void ReportRTCPFeedback(int ssrc, int seq_num) {
28 RTCPReportBlock report_block;
29 report_block.sourceSSRC = ssrc;
30 report_block.extendedHighSeqNum = seq_num;
31 report_blocks_.push_back(report_block);
32 playout_delay_oracle_.OnReceivedRtcpReceiverReport(report_blocks_);
33 }
34
35 ReportBlockList report_blocks_;
36 PlayoutDelayOracle playout_delay_oracle_;
37 };
38
39 TEST_F(PlayoutDelayOracleTest, DisabledByDefault) {
40 EXPECT_FALSE(playout_delay_oracle_.send_playout_delay());
41 EXPECT_EQ(playout_delay_oracle_.min_playout_delay_ms(), -1);
42 EXPECT_EQ(playout_delay_oracle_.max_playout_delay_ms(), -1);
danilchap 2016/06/03 09:01:37 this is same line as next one
Irfan 2016/06/03 15:55:33 Done.
43 EXPECT_EQ(playout_delay_oracle_.max_playout_delay_ms(), -1);
44 }
45
46 TEST_F(PlayoutDelayOracleTest, SendPlayoutDelayUntilSeqNumberExceeds) {
47 PlayoutDelay playout_delay = {kMinPlayoutDelay, kMaxPlayoutDelay};
48 playout_delay_oracle_.UpdateRequest(kSsrc, playout_delay, kSequenceNumber);
49 EXPECT_TRUE(playout_delay_oracle_.send_playout_delay());
50 EXPECT_EQ(playout_delay_oracle_.min_playout_delay_ms(), kMinPlayoutDelay);
51 EXPECT_EQ(playout_delay_oracle_.max_playout_delay_ms(), kMaxPlayoutDelay);
52
53 // Oracle indicates playout delay should be sent if highest sequence number
54 // acked is lower than the sequence number of the first packet containing
55 // playout delay.
56 ReportRTCPFeedback(kSsrc, kSequenceNumber - 1);
57 EXPECT_TRUE(playout_delay_oracle_.send_playout_delay());
58
59 // An invalid ssrc feedback report is dropped by the oracle.
60 ReportRTCPFeedback(kSsrc + 1, kSequenceNumber + 1);
61 EXPECT_TRUE(playout_delay_oracle_.send_playout_delay());
62
63 // Oracle indicates playout delay should not be sent if sequence number
64 // acked on a matching ssrc indicates the receiver has received the playout
65 // delay values.
66 ReportRTCPFeedback(kSsrc, kSequenceNumber + 1);
67 EXPECT_FALSE(playout_delay_oracle_.send_playout_delay());
68 }
69
70 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698