Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2007553003: Move H264BitstreamParser to video_coding. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
AlexG, åsapersson
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move H264BitstreamParser to video_coding. Moves parser, used in video_coding/ from rtp_rtcp where it is unused. BUG=webrtc:5678 R=asapersson@webrtc.org TBR=glaznev@webrt.org Committed: https://crrev.com/cc1543abf3126b9eacc73068407b85276c5eaf3e Cr-Commit-Position: refs/heads/master@{#12866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -718 lines) Patch
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/h264_bitstream_parser.h View 1 chunk +0 lines, -80 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/h264_bitstream_parser.cc View 1 chunk +0 lines, -565 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/h264_bitstream_parser_unittest.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + webrtc/modules/video_coding/utility/h264_bitstream_parser.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/video_coding/utility/h264_bitstream_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/video_coding/utility/h264_bitstream_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/video_coding_utility.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pbos-webrtc
PTAL
4 years, 7 months ago (2016-05-24 10:09:22 UTC) #1
åsapersson
lgtm
4 years, 7 months ago (2016-05-24 10:13:29 UTC) #2
pbos-webrtc
TBR=glaznev@ for webrtc/api/java/jni/androidmediaencoder_jni.cc (just updating a header)
4 years, 7 months ago (2016-05-24 10:16:03 UTC) #5
pbos-webrtc
4 years, 7 months ago (2016-05-24 10:16:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc1543abf3126b9eacc73068407b85276c5eaf3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698