Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: webrtc/p2p/base/p2pconstants.cc

Issue 2006903004: Revert of Change the size of the ICE ufrag to 4 bytes (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/p2p/base/p2ptransportchannel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/p2pconstants.cc
diff --git a/webrtc/p2p/base/p2pconstants.cc b/webrtc/p2p/base/p2pconstants.cc
index 64e5a13cf8b3132aa738c2519c3c931d51c5146c..fd75984a08e93b114cabde2b66780c3e41dc7c25 100644
--- a/webrtc/p2p/base/p2pconstants.cc
+++ b/webrtc/p2p/base/p2pconstants.cc
@@ -21,8 +21,9 @@
const char GROUP_TYPE_BUNDLE[] = "BUNDLE";
-// Minimum ufrag length is 4 characters as per RFC5245.
-const int ICE_UFRAG_LENGTH = 4;
+// Minimum ufrag length is 4 characters as per RFC5245. We chose 16 because
+// some internal systems expect username to be 16 bytes.
+const int ICE_UFRAG_LENGTH = 16;
// Minimum password length of 22 characters as per RFC5245. We chose 24 because
// some internal systems expect password to be multiple of 4.
const int ICE_PWD_LENGTH = 24;
« no previous file with comments | « no previous file | webrtc/p2p/base/p2ptransportchannel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698