Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 2006903004: Revert of Change the size of the ICE ufrag to 4 bytes (Closed)

Created:
4 years, 7 months ago by Zhi Huang
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Change the size of the ICE ufrag to 4 bytes (patchset #5 id:80001 of https://codereview.webrtc.org/1848083002/ ) Reason for revert: Break the build on Win32. Original issue's description: > Change the size of the ICE ufrag to 4 bytes. > > This is the minumum allowed size, and will allow STUN pings to be smaller. > The unit tests on the the Gturn are also modified. A username with length of 16 bytes will be generated for Gturn only. > > Committed: https://crrev.com/6d0d4bf31de1e36cab276ec3db994a952ba4b612 > Cr-Commit-Position: refs/heads/master@{#12876} TBR=deadbeef@webrtc.org,pthatcher@webrtc.org,zhihuang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M webrtc/p2p/base/p2pconstants.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/p2p/base/portallocator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Zhi Huang
Created Revert of Change the size of the ICE ufrag to 4 bytes
4 years, 7 months ago (2016-05-24 17:30:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006903004/1
4 years, 7 months ago (2016-05-24 17:30:27 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 17:30:29 UTC) #4
No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698