Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2006893003: Set IOS Wifi interface type based on the interface name. (Closed)

Created:
4 years, 6 months ago by honghaiz3
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, juberti1
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set IOS Wifi interface type based on the interface name. BUG=webrtc:3149 R=pthatcher@webrtc.org Committed: https://crrev.com/63ab810ce2e81c1e5ca0e8fa91d02958f0bda147 Cr-Commit-Position: refs/heads/master@{#12939}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M webrtc/base/network.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/base/network_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
honghaiz3
4 years, 6 months ago (2016-05-24 20:37:05 UTC) #3
honghaiz3
4 years, 6 months ago (2016-05-24 20:37:26 UTC) #4
pthatcher1
lgtm https://codereview.webrtc.org/2006893003/diff/20001/webrtc/base/network.cc File webrtc/base/network.cc (right): https://codereview.webrtc.org/2006893003/diff/20001/webrtc/base/network.cc#newcode811 webrtc/base/network.cc:811: // "unknown" type. // TODO(honghaiz): Write a proper ...
4 years, 6 months ago (2016-05-26 21:44:14 UTC) #6
honghaiz3
https://codereview.webrtc.org/2006893003/diff/20001/webrtc/base/network.cc File webrtc/base/network.cc (right): https://codereview.webrtc.org/2006893003/diff/20001/webrtc/base/network.cc#newcode811 webrtc/base/network.cc:811: // "unknown" type. On 2016/05/26 21:44:14, pthatcher1 wrote: > ...
4 years, 6 months ago (2016-05-27 01:03:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006893003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006893003/40001
4 years, 6 months ago (2016-05-27 01:04:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 6 months ago (2016-05-27 03:05:10 UTC) #12
honghaiz3
4 years, 6 months ago (2016-05-27 03:30:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
63ab810ce2e81c1e5ca0e8fa91d02958f0bda147 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698