Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2006423004: Making FakePortAllocator support IPv6. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Making FakePortAllocator support IPv6. FakePortAllocator is used with both virtual sockets and real sockets. Thus it needs to work on a system with no IPv4 interface. R=pthatcher@webrtc.org Committed: https://crrev.com/b787d875046f0d35e44aa1aba414852f050fa440 Cr-Commit-Position: refs/heads/master@{#12995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M webrtc/p2p/base/fakeportallocator.h View 6 chunks +34 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Taylor Brandstetter
4 years, 7 months ago (2016-05-26 00:06:02 UTC) #2
pthatcher1
lgtm
4 years, 6 months ago (2016-06-01 01:59:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006423004/1
4 years, 6 months ago (2016-06-01 15:33:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 6 months ago (2016-06-01 17:33:51 UTC) #7
Taylor Brandstetter
4 years, 6 months ago (2016-06-01 17:43:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b787d875046f0d35e44aa1aba414852f050fa440 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698