Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: webrtc/voice_engine/test/auto_test/standard/external_media_test.cc

Issue 2006243002: Revert of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/voice_engine/channel.cc ('k') | webrtc/voice_engine/utility.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/test/auto_test/standard/external_media_test.cc
diff --git a/webrtc/voice_engine/test/auto_test/standard/external_media_test.cc b/webrtc/voice_engine/test/auto_test/standard/external_media_test.cc
index 4534e128b3a76da6302bc68e8f34383a0463984d..4f86010a18aa099d3970b3048d06c99bd5af11d4 100644
--- a/webrtc/voice_engine/test/auto_test/standard/external_media_test.cc
+++ b/webrtc/voice_engine/test/auto_test/standard/external_media_test.cc
@@ -107,3 +107,20 @@
EXPECT_EQ(0, voe_xmedia_->SetExternalMixing(channel_, false));
ResumePlaying();
}
+
+TEST_F(ExternalMediaTest,
+ ExternalMixingResamplingToInvalidFrequenciesFails) {
+ const int kInvalidFrequencies[] = {-8000, -1};
+ webrtc::AudioFrame frame;
+ PausePlaying();
+ EXPECT_EQ(0, voe_xmedia_->SetExternalMixing(channel_, true));
+ ResumePlaying();
+ for (size_t i = 0; i < arraysize(kInvalidFrequencies); i++) {
+ int f = kInvalidFrequencies[i];
+ EXPECT_EQ(-1, voe_xmedia_->GetAudioFrame(channel_, f, &frame))
+ << "Resampling fails for freq=" << f;
+ }
+ PausePlaying();
+ EXPECT_EQ(0, voe_xmedia_->SetExternalMixing(channel_, false));
+ ResumePlaying();
+}
« no previous file with comments | « webrtc/voice_engine/channel.cc ('k') | webrtc/voice_engine/utility.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698