Revert of Adding a some checks and switching out a few assert for RTC_[D]CHECK.

Revert of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (patchset #6 id:100001 of https://codereview.webrtc.org/2007563002/ )

Reason for revert:
Reverting temporarily.  Need to fix tests downstream that pass invalid arguments.

Original issue's description:
> Adding a some checks and switching out a few assert for RTC_[D]CHECK.
> These changes are around use of AudioFrame.data_ to help us catch issues earlier since assert() is left out in release builds, including builds with DCHECK enabled.  I've also added a few full-on CHECKs to avoid reading past buffer boundaries or continuing on in a failed state.
>
> BUG=chromium:613482
> NOTRY=true
> (using notry due to offline android_arm64_rel bot)
>
> Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b
> Cr-Commit-Position: refs/heads/master@{#12870}

TBR=henrik.lundin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:613482
Committed: https://crrev.com/fb98b9edb445244cf5ad7fa7a69a5a95da854fd7
Cr-Commit-Position: refs/heads/master@{#12874}

[tommi, 2016-05-24 13:44:10]

Created Revert of Adding a some checks and switching out a few assert for
RTC_[D]CHECK.

[commit-bot: I haz the power, 2016-05-24 13:44:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006243002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006243002/1

[commit-bot: I haz the power, 2016-05-24 13:44:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-24 13:44:43]

Description was changed from

==========
Revert of Adding a some checks and switching out a few assert for RTC_[D]CHECK.
(patchset #6 id:100001 of https://codereview.webrtc.org/2007563002/ )

Reason for revert:
Reverting temporarily.  Need to fix tests downstream that pass invalid
arguments.

Original issue's description:
> Adding a some checks and switching out a few assert for RTC_[D]CHECK.
> These changes are around use of AudioFrame.data_ to help us catch issues
earlier since assert() is left out in release builds, including builds with
DCHECK enabled.  I've also added a few full-on CHECKs to avoid reading past
buffer boundaries or continuing on in a failed state.
> 
> BUG=chromium:613482
> NOTRY=true
> (using notry due to offline android_arm64_rel bot)
> 
> Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b
> Cr-Commit-Position: refs/heads/master@{#12870}

TBR=henrik.lundin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:613482
==========

to

==========
Revert of Adding a some checks and switching out a few assert for RTC_[D]CHECK.
(patchset #6 id:100001 of https://codereview.webrtc.org/2007563002/ )

Reason for revert:
Reverting temporarily.  Need to fix tests downstream that pass invalid
arguments.

Original issue's description:
> Adding a some checks and switching out a few assert for RTC_[D]CHECK.
> These changes are around use of AudioFrame.data_ to help us catch issues
earlier since assert() is left out in release builds, including builds with
DCHECK enabled.  I've also added a few full-on CHECKs to avoid reading past
buffer boundaries or continuing on in a failed state.
>
> BUG=chromium:613482
> NOTRY=true
> (using notry due to offline android_arm64_rel bot)
>
> Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b
> Cr-Commit-Position: refs/heads/master@{#12870}

TBR=henrik.lundin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:613482

Committed: https://crrev.com/fb98b9edb445244cf5ad7fa7a69a5a95da854fd7
Cr-Commit-Position: refs/heads/master@{#12874}
==========

[commit-bot: I haz the power, 2016-05-24 13:44:44]

Patchset 1 (id:??) landed as
https://crrev.com/fb98b9edb445244cf5ad7fa7a69a5a95da854fd7
Cr-Commit-Position: refs/heads/master@{#12874}

[hlundin-webrtc, 2016-05-24 13:47:27]

lgtm

[tommi, 2016-05-26 08:13:35]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2009253004/ by tommi@webrtc.org.

The reason for reverting is: Relanding.