Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2005993002: Remove timing dependent packet checks from socket tests. (Closed)

Created:
4 years, 7 months ago by stefan-webrtc
Modified:
4 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove timing dependent packet checks from socket tests. This avoids flaky tests and the check itself doesn't provide much value anyway. TBR=pthatcher@webrtc.org Committed: https://crrev.com/5b53b0eeb4068bd446c2f41939ea51113b73fc26 Cr-Commit-Position: refs/heads/master@{#12855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M webrtc/base/testclient.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/testclient.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
stefan-webrtc
4 years, 7 months ago (2016-05-23 20:24:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005993002/1
4 years, 7 months ago (2016-05-23 20:24:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/10351)
4 years, 7 months ago (2016-05-23 20:54:38 UTC) #8
stefan-webrtc
4 years, 7 months ago (2016-05-23 20:56:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b53b0eeb4068bd446c2f41939ea51113b73fc26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698