Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h

Issue 2005873002: Let PacketSource::NextPacket() return an std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h ('K') | « webrtc/modules/audio_coding/neteq/tools/packet_source.h ('k') | webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.cc » ('j') | webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h
diff --git a/webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h b/webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h
index ad7add154c5a1d3371f78ad85e0f4b89933223c1..71bf841bde8871947ba866f91a85815a55786a5a 100644
--- a/webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h
+++ b/webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h
@@ -38,9 +38,7 @@ class RtcEventLogSource : public PacketSource {
// Registers an RTP header extension and binds it to |id|.
virtual bool RegisterRtpHeaderExtension(RTPExtensionType type, uint8_t id);
- // Returns a pointer to the next packet. Returns NULL if end of file was
- // reached.
kwiberg-webrtc 2016/05/24 09:04:56 Why is this comment no longer needed?
hlundin-webrtc 2016/05/24 10:59:15 Same as before.
- Packet* NextPacket() override;
+ std::unique_ptr<Packet> NextPacket() override;
// Returns the timestamp of the next audio output event, in milliseconds. The
// maximum value of int64_t is returned if there are no more audio output
« webrtc/modules/audio_coding/neteq/tools/constant_pcm_packet_source.h ('K') | « webrtc/modules/audio_coding/neteq/tools/packet_source.h ('k') | webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.cc » ('j') | webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698